Skip to content

Commit a81d10d

Browse files
committed
fix(init): Don't set 'base_ref' on github-release events
We were previously setting this to the tag of the release, but run-task doesn't handle the case where base_ref is a tag well. This could be fixed, but the release tag is the `head_ref` rather than the `base_ref`. So it's best to just not pass it in at all in this case.
1 parent 1d5be19 commit a81d10d

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.taskcluster.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ tasks:
5252
# [1] https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#push
5353
'tasks_for == "github-push" && event.base_ref': ${event.base_ref}
5454
'tasks_for == "github-push" && !(event.base_ref)': ${event.ref}
55-
'tasks_for == "github-release"': ${event.release.tag_name}
55+
'tasks_for == "github-release"': ''
5656
'tasks_for in ["cron", "action"]': '${push.branch}'
5757
'tasks_for == "pr-action"': '${push.base_branch}'
5858
head_ref:

template/{{cookiecutter.project_name}}/taskcluster.github.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ tasks:
4646
'tasks_for[:19] == "github-pull-request"': ${event.pull_request.base.ref}
4747
'tasks_for == "github-push" && event.base_ref': ${event.base_ref}
4848
'tasks_for == "github-push"': ${event.ref}
49-
'tasks_for == "github-release"': ${event.release.tag_name}
49+
'tasks_for == "github-release"': ''
5050
'tasks_for in ["cron", "action"]': '${push.branch}'
5151
'tasks_for == "pr-action"': '${push.base_branch}'
5252
head_ref:

0 commit comments

Comments
 (0)