fix: update dependencies attribute in optimize.get_subgraph

I don't think this attribute really gets used past the optimization
phase, but the fact it wasn't being updated tripped up a test I was
working on, so figured it doesn't hurt to keep it consistent.

Author: ahal

packages/pytest-taskgraph/src/pytest_taskgraph/fixtures/gen.py

@@ -258,6 +258,7 @@ def make_task(
     }
     task = Task(
         attributes=attributes or {},
+        dependencies=dependencies or {},
         if_dependencies=if_dependencies or [],
         kind=kind,
         label=label,
@@ -266,7 +267,13 @@ def make_task(
     task.optimization = optimization
     task.task_id = task_id
     if dependencies is not None:
-        task.task["dependencies"] = sorted(dependencies)
+        # The dependencies dict is converted from a dict to a list during the
+        # optimization phase. This is pretty confusing and means this utility
+        # might break assumptions about the format of 'dependencies'.
+        if isinstance(dependencies, dict):
+            task.task["dependencies"] = sorted(dependencies.values())
+        else:
+            task.task["dependencies"] = sorted(dependencies)
     return task
 
 

src/taskgraph/optimize/base.py

@@ -437,6 +437,7 @@ def get_subgraph(
         )
         deps = task.task.setdefault("dependencies", [])
         deps.extend(sorted(named_task_dependencies.values()))
+        task.dependencies.update(named_task_dependencies)
         tasks_by_taskid[task.task_id] = task
 
     # resolve edges to taskIds

test/test_optimize.py

@@ -410,8 +410,10 @@ def test_replace_tasks(
             {},
             make_opt_graph(
                 make_task("t1", task_id="tid1", dependencies={}),
-                make_task("t2", task_id="tid2", dependencies={"tid1"}),
-                make_task("t3", task_id="tid3", dependencies={"tid1", "tid2"}),
+                make_task("t2", task_id="tid2", dependencies={"dep": "tid1"}),
+                make_task(
+                    "t3", task_id="tid3", dependencies={"dep": "tid2", "dep2": "tid1"}
+                ),
                 ("tid3", "tid2", "dep"),
                 ("tid3", "tid1", "dep2"),
                 ("tid2", "tid1", "dep"),
@@ -438,7 +440,11 @@ def test_replace_tasks(
                 "label_to_taskid": {"t1": "e1", "t2": "e2"},
             },
             # expectations
-            make_opt_graph(make_task("t3", task_id="tid1", dependencies={"e1", "e2"})),
+            make_opt_graph(
+                make_task(
+                    "t3", task_id="tid1", dependencies={"dep": "e2", "dep2": "e1"}
+                )
+            ),
             {"t1": "e1", "t2": "e2", "t3": "tid1"},
             id="replaced",
         ),