Skip to content

Commit f90c0fe

Browse files
pinguingmanzazymking
authored andcommitted
fix linters + test
1 parent bc45417 commit f90c0fe

File tree

2 files changed

+10
-15
lines changed

2 files changed

+10
-15
lines changed

taskiq_redis/redis_cluster_broker.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ async def kick(self, message: BrokerMessage) -> None:
6060
6161
:param message: message to append.
6262
"""
63-
await self.redis.lpush(self.queue_name, message.message)
63+
await self.redis.lpush(self.queue_name, message.message) # type: ignore[attr-defined]
6464

6565
async def listen(self) -> AsyncGenerator[bytes, None]:
6666
"""
@@ -73,6 +73,5 @@ async def listen(self) -> AsyncGenerator[bytes, None]:
7373
"""
7474
redis_brpop_data_position = 1
7575
while True:
76-
yield (await self.redis.brpop([self.queue_name]))[
77-
redis_brpop_data_position
78-
]
76+
value = await self.redis.brpop([self.queue_name]) # type: ignore[attr-defined]
77+
yield value[redis_brpop_data_position]

tests/test_broker.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import pytest
66
from taskiq import AckableMessage, AsyncBroker, BrokerMessage
77

8-
from taskiq_redis import ListQueueBroker, PubSubBroker, ListQueueClusterBroker
8+
from taskiq_redis import ListQueueBroker, ListQueueClusterBroker, PubSubBroker
99

1010

1111
def test_no_url_should_raise_typeerror() -> None:
@@ -109,21 +109,17 @@ async def test_list_queue_cluster_broker(
109109
We create two workers that listen and send a message to them.
110110
Expect only one worker to receive the same message we sent.
111111
"""
112-
113-
print(f"redis_cluster_url: {redis_cluster_url}")
114112
broker = ListQueueClusterBroker(
115-
url=redis_cluster_url, queue_name=uuid.uuid4().hex
113+
url=redis_cluster_url,
114+
queue_name=uuid.uuid4().hex,
116115
)
117-
worker1_task = asyncio.create_task(get_message(broker))
118-
worker2_task = asyncio.create_task(get_message(broker))
116+
worker_task = asyncio.create_task(get_message(broker))
119117
await asyncio.sleep(0.3)
120118

121119
await broker.kick(valid_broker_message)
122120
await asyncio.sleep(0.3)
123121

124-
assert worker1_task.done() != worker2_task.done()
125-
message = worker1_task.result() if worker1_task.done() else worker2_task.result()
126-
assert message == valid_broker_message.message
127-
worker1_task.cancel()
128-
worker2_task.cancel()
122+
assert worker_task.done()
123+
assert worker_task.result() == valid_broker_message.message
124+
worker_task.cancel()
129125
await broker.shutdown()

0 commit comments

Comments
 (0)