Skip to content

Commit b207994

Browse files
authored
Removed Queue logging handler (#67)
1 parent 72bfbef commit b207994

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,5 @@ jobs:
5656
if: matrix.os == 'ubuntu-latest' && matrix.py_version == '3.9'
5757
with:
5858
token: ${{ secrets.CODECOV_TOKEN }}
59-
fail_ci_if_error: true
59+
fail_ci_if_error: false
6060
verbose: true

taskiq/cli/worker/process_manager.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ def handle(
7575
daemon=True,
7676
)
7777
new_process.start()
78+
logger.info(f"Process {new_process.name} restarted with pid {new_process.pid}")
7879
workers[self.worker_num] = new_process
7980

8081

@@ -163,12 +164,12 @@ def prepare_workers(self) -> None:
163164
name=f"worker-{process}",
164165
daemon=True,
165166
)
167+
work_proc.start()
166168
logger.info(
167169
"Started process worker-%d with pid %s ",
168170
process,
169171
work_proc.pid,
170172
)
171-
work_proc.start()
172173
self.workers.append(work_proc)
173174

174175
def start(self) -> None: # noqa: C901, WPS213

taskiq/cli/worker/run.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
import asyncio
22
import logging
33
import signal
4-
import sys
5-
from logging.handlers import QueueHandler, QueueListener
6-
from multiprocessing import Queue
74
from typing import Any
85

96
from watchdog.observers import Observer
@@ -120,15 +117,11 @@ def run_worker(args: WorkerArgs) -> None: # noqa: WPS213
120117
121118
:param args: CLI arguments.
122119
"""
123-
logging_queue = Queue(-1) # type: ignore
124-
listener = QueueListener(logging_queue, logging.StreamHandler(sys.stdout))
125120
logging.basicConfig(
126121
level=logging.getLevelName(args.log_level),
127122
format="[%(asctime)s][%(name)s][%(levelname)-7s][%(processName)s] %(message)s",
128-
handlers=[QueueHandler(logging_queue)],
129123
)
130124
logging.getLogger("watchdog.observers.inotify_buffer").setLevel(level=logging.INFO)
131-
listener.start()
132125
logger.info("Starting %s worker processes.", args.workers)
133126

134127
observer = Observer()
@@ -149,4 +142,3 @@ def run_worker(args: WorkerArgs) -> None: # noqa: WPS213
149142
logger.info("Stopping watching files.")
150143
observer.stop()
151144
logger.info("Stopping logging thread.")
152-
listener.stop()

0 commit comments

Comments
 (0)