Preserve context vars for sync tasks #483
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The one for sync fails ATM. For async is OK.
Run sync tasks within copied context. This is heavily inspired by starlette's `run_in_threadpool` function introduced in encode/starlette#192.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #482
Run sync tasks within copied context.
This is heavily inspired by starlette's
run_in_threadpoolfunctionintroduced in encode/starlette#192.
Nowadays, starlette is just using anyio.to_thread.run_sync, which does a bunch of extra stuff too,
but from my (limited) understanding,
introducing that would require some changes to the architecture of the project itself 🤔. IDK.