Skip to content

chore: upgrade to v18 #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hoebbelsB wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: upgrade to v18 #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
884b9a4
chore: upgrade to v18
hoebbelsB Aug 29, 2024
35f88d7
chore: fix ci
hoebbelsB Aug 29, 2024
1ee6ec2
chore: fix ci
hoebbelsB Aug 29, 2024
db51088
chore: fix build
hoebbelsB Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,41 +4,37 @@ on:
push:
branches:
- main
-
env:
NX_NON_NATIVE_HASHER: true

jobs:
ci:
runs-on: ubuntu-latest
steps:
# needed for all cases
- if: github.event_name == 'push' && github.ref_name == 'main'
uses: actions/checkout@v3
uses: actions/checkout@v4
# needed for nx affected command
- if: github.event_name == 'pull_request'
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
# needed for nx affected command
- if: github.event_name == 'pull_request'
run: git fetch --no-tags --depth=1 origin $BASE_BRANCH

- name: Setup Node.js
uses: actions/setup-node@v3

- uses: actions/setup-node@v4
with:
node-version: '18'
cache: npm
node-version: 20
cache: 'npm'

- name: Install dependencies
run: npm ci

- uses: nrwl/nx-set-shas@v4

# TODO: have different dist locations to run in parallel
- name: Run Nx Affected lint,test
run: npx nx affected --targets=lint,test
run: npx nx affected --t lint,test
- name: Run Nx Affected build
run: npx nx affected --targets=build --exclude docs
- name: Run build docs
run: npx nx build docs
- name: Run Nx Affected prerende
run: npx nx affected --targets=prerende
# - name: Run Nx Affected prerende
# run: npx nx affected --targets=prerender
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,6 @@ testem.log
Thumbs.db

.angular

.nx/cache
.nx/workspace-data
2 changes: 1 addition & 1 deletion .lintstagedrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"*.ts": ["prettier --write", "eslint --fix"],
"*.ts": ["prettier --write", "eslint --quiet --fix"],
"*.scss": ["prettier --write", "stylelint --fix"],
"*.{html,js,json}": ["prettier --write"]
}
3 changes: 3 additions & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@ dist
coverage

.angular

/.nx/cache
/.nx/workspace-data
51 changes: 25 additions & 26 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,35 +24,34 @@ For now you can search the codebase for "Perf Tip" later on there will be proppe

### Bundle Stats

<!-- bundle-stats-start -->

| Names | Size |
| ----------------------------------------------------------------------------------- | ------------- |
| main.js | 343.15 KB |
| styles.css | 6.17 KB |
| runtime.js | 2.61 KB |
| **Initial Total** | **351.93 KB** |
| Names | Size |
| app_pages_movie-detail-page_movie-detail-page_component_ts.js | 16.83 KB |
| app_pages_person-detail-page_person-detail-page_component_ts.js | 11.79 KB |
| a-6a8199.js | 10.07 KB |
| app_pages_account-feature_list-detail-page_list-movies_list-movies_compon-d13d08.js | 9.83 KB |
| common.js | 7.69 KB |
| app_pages_account-feature_list-detail-page_list-items-edit_list-items-edi-13eb42.js | 7.23 KB |
| app_pages_movie-list-page_movie-list-page_component_ts.js | 5.84 KB |
| app_pages_account-feature_list-create-page_list-create-page_component_ts--1f481e.js | 5.7 KB |
| app_app-shell_account-menu_account-menu_component_ts.js | 5.63 KB |
| app_pages_account-feature_account-list-page_account-list-page_component_ts.js | 4.89 KB |
| app_pages_account-feature_list-detail-page_list-image_list-image_componen-cb4b89.js | 4.36 KB |
| default-node_modules_rx-angular_template_fesm2022_template-if_mjs.js | 4.23 KB |
| app_pages_account-feature_list-detail-page_list-remove_list-remove_compon-a10eb2.js | 3.41 KB |
| app_pages_account-feature_list-detail-page_list-detail-page_component_ts--a2c81d.js | 3.24 KB |
| app_pages_not-found-page_not-found-page_component_ts.js | 1.77 KB |
| app_pages_account-feature_list-detail-page_list-detail-page_routes_ts.js | 1.54 KB |
| app_pages_account-feature_account-feature-page_routes_ts.js | 926 Bytes |

<!-- bundle-stats-start -->
| Names | Size |
| --- | --- |
| main.js | 369.67 KB |
| styles.css | 6.17 KB |
| runtime.js | 2.61 KB |
| **Initial Total** | **378.45 KB** |
| Names | Size |
| app_pages_movie-detail-page_movie-detail-page_component_ts.js | 16.56 KB |
| a-4d8953.js | 13.09 KB |
| app_pages_person-detail-page_person-detail-page_component_ts.js | 11.81 KB |
| app_pages_account-feature_list-create-page_list-create-page_component_ts--1f481e.js | 9.43 KB |
| app_app-shell_account-menu_account-menu_component_ts.js | 9.36 KB |
| common.js | 8.5 KB |
| app_pages_account-feature_list-detail-page_list-items-edit_list-items-edi-13eb42.js | 7.25 KB |
| app_pages_movie-list-page_movie-list-page_component_ts.js | 5.89 KB |
| app_pages_account-feature_account-list-page_account-list-page_component_ts.js | 4.92 KB |
| app_pages_account-feature_list-detail-page_list-image_list-image_componen-cb4b89.js | 4.39 KB |
| app_pages_account-feature_list-detail-page_list-remove_list-remove_compon-a10eb2.js | 3.39 KB |
| app_pages_account-feature_list-detail-page_list-detail-page_component_ts--a2c81d.js | 3.24 KB |
| app_pages_not-found-page_not-found-page_component_ts.js | 1.79 KB |
| app_pages_account-feature_list-detail-page_list-detail-page_routes_ts.js | 1.5 KB |
| app_pages_account-feature_account-feature-page_routes_ts.js | 852 Bytes |
| app_pages_account-feature_list-detail-page_list-movies_list-movies_component_ts.js | 678 Bytes |
<!-- bundle-stats-end -->


## Comparison to next and nuxt

- [angular](https://angular-movies-a12d3.web.app/list/category/popular)
Expand Down
Loading