refactor(api): change listRegisteredResources to instance method

Author: sampoyigi

src/Classes/ApiManager.php

@@ -53,7 +53,7 @@ protected function loadResources()
     {
         Resource::syncAll();
 
-        $resources = Resource::all()->mapWithKeys(function(Resource $resource) {
+        $resources = Resource::all()->mapWithKeys(function(Resource $resource): array {
             $resourceObj = (object)[
                 'endpoint' => $resource->endpoint,
                 'controller' => $resource->controller,

src/Models/Resource.php

@@ -89,7 +89,7 @@ public function getControllerAttribute()
 
     public function getAvailableActions(): array
     {
-        $registeredResource = array_get(static::listRegisteredResources(), $this->endpoint, []);
+        $registeredResource = array_get((new static)->listRegisteredResources(), $this->endpoint, []);
         $registeredActions = array_get($registeredResource, 'options.actions', []);
         $dbActions = (array)array_get($this->meta, 'actions', []);
 
@@ -157,7 +157,7 @@ public static function getResources()
      */
     public static function listResources()
     {
-        $registeredResources = static::listRegisteredResources();
+        $registeredResources = (new static)->listRegisteredResources();
         $dbResources = static::all()->keyBy('endpoint')->all();
         $resources = $registeredResources + $dbResources;
         ksort($resources);
@@ -195,7 +195,7 @@ protected function processOptions($definition): array
      * Returns a list of the registered resources.
      * @return array
      */
-    public static function listRegisteredResources()
+    public function listRegisteredResources()
     {
         if (static::$registeredResources === null) {
             (new static)->loadRegisteredResources();

tests/ExtensionTest.php

@@ -14,7 +14,7 @@
 use Mockery;
 
 it('loads registered api resources', function(): void {
-    $resources = Resource::listRegisteredResources();
+    $resources = (new Resource)->listRegisteredResources();
 
     expect($resources)
         ->toHaveKey('categories')

tests/Models/ResourceTest.php

@@ -4,8 +4,10 @@
 
 namespace Igniter\Api\Tests\Models;
 
+use Igniter\Api\ApiResources\Categories;
 use Igniter\Api\Models\Resource;
 use Igniter\Flame\Database\Traits\HasPermalink;
+use Igniter\System\Classes\ExtensionManager;
 use Mockery;
 
 it('returns default action definition when no meta options are set', function(): void {
@@ -41,6 +43,22 @@ public function testGet()
 });
 
 it('syncs all resources correctly', function(): void {
+    app()->instance(ExtensionManager::class, mock(ExtensionManager::class, function($mock) {
+        $mock->shouldReceive('getRegistrationMethodValues')
+            ->with('registerApiResources')
+            ->andReturn([
+                'igniter.custom' => [
+                    'custom' => [
+                        'controller' => Categories::class,
+                        'name' => 'Custom',
+                        'description' => 'An API resource for categories',
+                        'actions' => [
+                            'index', 'show:all', 'store:admin', 'update:admin', 'destroy:admin',
+                        ],
+                    ],
+                ],
+            ]);
+    }));
     Resource::factory()->create(['endpoint' => 'endpoint1', 'is_custom' => true]);
     Resource::factory()->create(['endpoint' => 'endpoint2']);
     Resource::clearInternalCache();