don't warn for BP usage on stocks/ETFs

Author: Graeme22

ttcli/portfolio.py

@@ -1,12 +1,12 @@
 from collections import defaultdict
 from datetime import date, datetime
 from decimal import Decimal
-from typing import Annotated, cast
+from typing import Annotated
 
 from rich.console import Console
 from rich.table import Table
 from tastytrade import DXLinkStreamer
-from tastytrade.account import MarginReportEntry
+from tastytrade.account import EmptyDict
 from tastytrade.dxfeed import Greeks
 from tastytrade.instruments import (
     Cryptocurrency,
@@ -545,17 +545,16 @@ def margin():
         "portfolio", "bp-max-percent-per-position", fallback=5.0
     )
     for i, entry in enumerate(margin.groups):
-        if not entry:
+        if isinstance(entry, EmptyDict):
             continue
-        entry = cast(MarginReportEntry, entry)
         bp = -entry.buying_power
         bp_percent = abs(float(bp / margin.margin_equity * 100))
-        if abs(bp_percent) > max_percent:
+        if abs(bp_percent) > max_percent and entry.underlying_type != "Equity":
             warnings.append(
                 f"Per-position BP usage is too high for {entry.description}, max is {max_percent}%!"
             )
         table.add_row(
-            *[entry.description, conditional_color(bp), f"{bp_percent:.1f}%"],
+            *[entry.code, conditional_color(bp), f"{bp_percent:.1f}%"],
             end_section=(i == last_entry),
         )
     bp_percent = abs(round(margin.margin_requirement / margin.margin_equity * 100, 1))

ttcli/utils.py

@@ -138,9 +138,8 @@ def __init__(self):
     def _get_credentials(self):
         username = os.getenv("TT_USERNAME")
         password = os.getenv("TT_PASSWORD")
-        if self.config.has_section("general"):
-            username = username or self.config["general"].get("username")
-            password = password or self.config["general"].get("password")
+        username = username or self.config.get("general", "username", fallback=None)
+        password = password or self.config.get("general", "password", fallback=None)
 
         if not username:
             username = getpass.getpass("Username: ")
@@ -150,15 +149,16 @@ def _get_credentials(self):
         return username, password
 
     def get_account(self) -> Account:
-        account = self.config["general"].get("default-account", None)
+        if len(self.accounts) == 1:  # auto-select if there's only 1 option
+            return self.accounts[0]
+        account = self.config.get("general", "default-account", fallback=None)
         if account:
             try:
                 return next(a for a in self.accounts if a.account_number == account)
             except StopIteration:
                 print_warning(
                     "Default account is set, but the account doesn't appear to exist!"
                 )
-
         for i in range(len(self.accounts)):
             if i == 0:
                 print(