refactor: Simplify connection tests by removing redundant setup and verifying node relationships directly

Author: tasuku43

tests/ClassDiagramRenderer/Node/Connector/CompositionConnectorTest.php

@@ -21,25 +21,22 @@ class CompositionConnectorTest extends TestCase
      */
     public function testConnect(): void
     {
-        // Set up diagram nodes
-        $containerNode = new DiagramClass('Container');
-        $containedNode = new DiagramClass('Contained');
-        
-        // Set up nodes collection
+        $container = new DiagramClass('Container');
+        $contained = new DiagramClass('Contained');
+
         $nodes = new Nodes();
-        $nodes->add($containedNode);
-        $nodes->add($containerNode);
-        
-        // Create connector
+        $nodes->add($container);
+        $nodes->add($contained);
+
         $connector = new CompositionConnector('Container', ['Contained']);
-        
-        // Connect the nodes
         $connector->connect($nodes);
-        
-        // Verify the connection
-        $relationships = $containerNode->relationships();
-        $this->assertCount(1, $relationships);
-        $this->assertStringContainsString('Container *-- Contained: composition', $relationships[0]->render());
+
+        $node = $nodes->findByName('Container');
+
+        $expected = new DiagramClass('Container');
+        $expected->composition($contained);
+
+        $this->assertEquals($node, $expected);
     }
 
     /**

tests/ClassDiagramRenderer/Node/Connector/DependencyConnectorTest.php

@@ -21,25 +21,22 @@ class DependencyConnectorTest extends TestCase
      */
     public function testConnect(): void
     {
-        // Set up diagram nodes
-        $dependentNode = new DiagramClass('Dependent');
-        $dependencyNode = new DiagramClass('Dependency');
-        
-        // Set up nodes collection
+        $dependent = new DiagramClass('Dependent');
+        $dependency = new DiagramClass('Dependency');
+
         $nodes = new Nodes();
-        $nodes->add($dependencyNode);
-        $nodes->add($dependentNode);
-        
-        // Create connector
+        $nodes->add($dependent);
+        $nodes->add($dependency);
+
         $connector = new DependencyConnector('Dependent', ['Dependency']);
-        
-        // Connect the nodes
         $connector->connect($nodes);
-        
-        // Verify the connection
-        $relationships = $dependentNode->relationships();
-        $this->assertCount(1, $relationships);
-        $this->assertStringContainsString('Dependent ..> Dependency: dependency', $relationships[0]->render());
+
+        $node = $nodes->findByName('Dependent');
+
+        $expected = new DiagramClass('Dependent');
+        $expected->depend($dependency);
+
+        $this->assertEquals($node, $expected);
     }
 
     /**

tests/ClassDiagramRenderer/Node/Connector/InheritanceConnectorTest.php

@@ -22,25 +22,22 @@ class InheritanceConnectorTest extends TestCase
      */
     public function testConnect(): void
     {
-        // Set up diagram nodes
-        $childNode = new DiagramClass('Child');
-        $parentNode = new DiagramClass('Parent');
-        
-        // Set up nodes collection
+        $child = new DiagramClass('Child');
+        $parent = new DiagramClass('Parent');
+
         $nodes = new Nodes();
-        $nodes->add($parentNode);
-        $nodes->add($childNode);
-        
-        // Create connector
+        $nodes->add($child);
+        $nodes->add($parent);
+
         $connector = new InheritanceConnector('Child', ['Parent']);
-        
-        // Connect the nodes
         $connector->connect($nodes);
-        
-        // Verify the connection
-        $relationships = $childNode->relationships();
-        $this->assertCount(1, $relationships);
-        $this->assertStringContainsString('Parent <|-- Child: inheritance', $relationships[0]->render());
+
+        $node = $nodes->findByName('Child');
+
+        $expected = new DiagramClass('Child');
+        $expected->extends($parent);
+
+        $this->assertEquals($node, $expected);
     }
 
     /**

tests/ClassDiagramRenderer/Node/Connector/RealizationConnectorTest.php

@@ -22,25 +22,22 @@ class RealizationConnectorTest extends TestCase
      */
     public function testConnect(): void
     {
-        // Set up diagram nodes
-        $classNode = new DiagramClass('TestClass');
-        $interfaceNode = new DiagramInterface('TestInterface');
-        
-        // Set up nodes collection
+        $class = new DiagramClass('TestClass');
+        $interface = new DiagramInterface('TestInterface');
+
         $nodes = new Nodes();
-        $nodes->add($interfaceNode);
-        $nodes->add($classNode);
-        
-        // Create connector
+        $nodes->add($class);
+        $nodes->add($interface);
+
         $connector = new RealizationConnector('TestClass', ['TestInterface']);
-        
-        // Connect the nodes
         $connector->connect($nodes);
-        
-        // Verify the connection
-        $relationships = $classNode->relationships();
-        $this->assertCount(1, $relationships);
-        $this->assertStringContainsString('TestInterface <|.. TestClass: realization', $relationships[0]->render());
+
+        $node = $nodes->findByName('TestClass');
+
+        $expected = new DiagramClass('TestClass');
+        $expected->implements($interface);
+
+        $this->assertEquals($node, $expected);
     }
 
     /**

tests/ClassDiagramRenderer/Node/Connector/TraitUsageConnectorTest.php

@@ -22,21 +22,19 @@ public function testConnectRegistersTraitUsageOnly(): void
         $using = new DiagramClass('Using');
         $trait = new DiagramTrait('T');
 
-        // Trait declares composition(A) and dependency(B)
-        $trait->composition(new DiagramClass('A'));
-        $trait->depend(new DiagramClass('B'));
-
         $nodes = new Nodes();
         $nodes->add($using);
         $nodes->add($trait);
 
         $connector = new TraitUsageConnector('Using', ['T']);
         $connector->connect($nodes);
 
-        // Verify via node relationships (connector application)
-        $rendered = array_map(fn($r) => $r->render(), $using->relationships());
-        $this->assertTrue($this->contains($rendered, 'Using *-- A: composition'));
-        $this->assertTrue($this->contains($rendered, 'Using ..> B: dependency'));
+        $node = $nodes->findByName('Using');
+
+        $expected = new DiagramClass('Using');
+        $expected->useTrait($trait);
+
+        $this->assertEquals($node, $expected);
     }
 
     /**