Apply static analysis fixes

Author: MGatner

phpstan.neon.dist

@@ -10,7 +10,6 @@ parameters:
 		- src/Config/Routes.php
 		- src/Views/*
 	ignoreErrors:
-		- '#Cannot access property [\$a-z_]+ on (array|object)#'
 		- '#Unsafe usage of new static\(\)*#'
 	universalObjectCratesClasses:
 		- CodeIgniter\Entity

src/Alerts.php

@@ -22,9 +22,10 @@
 *
 ***/
 
-use CodeIgniter\Config\BaseConfig;
+use CodeIgniter\Session\Session;
 use CodeIgniter\View\RendererInterface;
 use Config\Services;
+use Tatter\Alerts\Config\Alerts as AlertsConfig;
 use Tatter\Alerts\Exceptions\AlertsException;
 
 /*** CLASS ***/
@@ -34,7 +35,7 @@ class Alerts
 	/**
 	 * Our configuration instance.
 	 *
-	 * @var \Tatter\Alerts\Config\Alerts
+	 * @var AlertsConfig
 	 */
 	protected $config;
 
@@ -48,12 +49,12 @@ class Alerts
 	/**
 	 * The active user session, for loading and storing alerts.
 	 *
-	 * @var \CodeIgniter\Session\Session
+	 * @var Session
 	 */
 	protected $session;	
 
 	// initiate library, check for existing session
-	public function __construct(BaseConfig $config, RendererInterface $view = null)
+	public function __construct(AlertsConfig $config, RendererInterface $view = null)
 	{
 		// save configuration
 		$this->config = $config;

src/Config/Services.php

@@ -1,23 +1,21 @@
 <?php namespace Tatter\Alerts\Config;
 
 use CodeIgniter\View\RendererInterface;
+use Config\Services as BaseServices;
+use Tatter\Alerts\Alerts;
+use Tatter\Alerts\Config\Alerts as AlertsConfig;
 
-class Services extends \Config\Services
+class Services extends BaseServices
 {
-    public static function alerts(BaseConfig $config = null, RendererInterface $view = null, bool $getShared = true)
+    public static function alerts(AlertsConfig $config = null, RendererInterface $view = null, bool $getShared = true)
     {
 		if ($getShared)
 		{
 			return static::getSharedInstance('alerts', $config, $view);
 		}
 
-		// If no config was injected then load one
-		// Prioritizes app/Config if found
-		if (empty($config))
-		{
-			$config = config('Alerts');
-		}
+		$config = $config ?? config('Alerts');
 
-		return new \Tatter\Alerts\Alerts($config, $view);
+		return new Alerts($config, $view);
 	}
 }