Begin static analysis

Author: MGatner

src/Config/Services.php

@@ -2,10 +2,13 @@
 
 use CodeIgniter\Config\BaseService;
 use CodeIgniter\View\RendererInterface;
+use Tatter\Assets\Libraries\Assets;
+use Tatter\Assets\Libraries\Manifests;
+use Tatter\Assets\Config\Assets as AssetsConfig;
 
 class Services extends BaseService
 {
-    public static function assets(BaseConfig $config = null, bool $getShared = true)
+    public static function assets(AssetsConfig $config = null, bool $getShared = true)
     {
 		if ($getShared)
 		{
@@ -18,10 +21,10 @@ public static function assets(BaseConfig $config = null, bool $getShared = true)
 		{
 			$config = config('Assets');
 		}
-		return new \Tatter\Assets\Libraries\Assets($config);
+		return new Assets($config);
 	}
 
-    public static function manifests(BaseConfig $config = null, bool $getShared = true)
+    public static function manifests(AssetsConfig $config = null, bool $getShared = true)
     {
 		if ($getShared)
 		{
@@ -34,6 +37,6 @@ public static function manifests(BaseConfig $config = null, bool $getShared = tr
 		{
 			$config = config('Assets');
 		}
-		return new \Tatter\Assets\Libraries\Manifests($config);
+		return new Manifests($config);
 	}
 }

src/Handlers/ConfigHandler.php

@@ -1,23 +1,30 @@
 <?php namespace Tatter\Assets\Handlers;
 
-use CodeIgniter\Config\BaseConfig;
 use Config\Services;
+use Tatter\Assets\Config\Assets as AssetsConfig;
 use Tatter\Assets\Exceptions\AssetsException;
 use Tatter\Assets\Handlers\DirectoryHandler;
 use Tatter\Assets\Interfaces\AssetHandlerInterface;
 
 class ConfigHandler implements AssetHandlerInterface
-{	
+{
+	/**
+	 * Our configuration instance.
+	 *
+	 * @var AssetsConfig
+	 */
+	protected $config;
+
 	/**
 	 * Instance of the directory handler for config routes
 	 * that point to directories instead of files.
 	 *
-	 * @var \Tatter\Assets\Handlers\DirectoryHandler
+	 * @var DirectoryHandler|null
 	 */
 	protected $directoryHandler;
 
 	// Save the config
-	public function __construct(BaseConfig $config = null)
+	public function __construct(AssetsConfig $config = null)
 	{
 		// Save the configuration
 		$this->config = $config ?? config('Assets');

src/Handlers/DirectoryHandler.php

@@ -1,13 +1,20 @@
 <?php namespace Tatter\Assets\Handlers;
 
-use CodeIgniter\Config\BaseConfig;
 use Config\Services;
+use Tatter\Assets\Config\Assets as AssetsConfig;
 use Tatter\Assets\Interfaces\AssetHandlerInterface;
 
 class DirectoryHandler implements AssetHandlerInterface
 {	
+	/**
+	 * Our configuration instance.
+	 *
+	 * @var AssetsConfig
+	 */
+	protected $config;
+
 	// Save the config and intiate the helper
-	public function __construct(BaseConfig $config = null)
+	public function __construct(AssetsConfig $config = null)
 	{
 		// Save the configuration
 		$this->config = $config ?? config('Assets');

src/Interfaces/AssetHandlerInterface.php

@@ -1,10 +1,10 @@
 <?php namespace Tatter\Assets\Interfaces;
 
-use CodeIgniter\Config\BaseConfig;
+use Tatter\Assets\Config\Assets as AssetsConfig;
 
 interface AssetHandlerInterface
 {
-	public function __construct(BaseConfig $config = null);
+	public function __construct(AssetsConfig $config = null);
 
 	public function gather(string $route): array;
 }

src/Libraries/Manifests.php

@@ -408,13 +408,13 @@ protected function publishFile(string $source, string $destination): bool
 
 		if ($this->config->silent)
 		{
-			$error = lang('Files.cannotMove', [$source, $destination, -1]);
+			$error = lang('Files.cannotMove', [$source, $destination, 'unknown error']);
 			log_message('warning', $error);
 			$this->messages[] = [$error, 'red'];
 
 			return false;
 		}
 
-		throw FileException::forUnableToMove($source, $destination, -1);
+		throw FileException::forUnableToMove($source, $destination, 'unknown error');
 	}
 }