Apply Psalm return types

Author: MGatner

src/Commands/HandlersCache.php

@@ -14,6 +14,9 @@ class HandlersCache extends BaseCommand
     protected $description = 'Discovers and caches all handlers';
     protected $usage       = 'handlers:cache';
 
+    /**
+     * @return void
+     */
     public function run(array $params = [])
     {
         // Make sure caching is enabled

src/Commands/HandlersClear.php

@@ -12,6 +12,9 @@ class HandlersClear extends BaseCommand
     protected $description = 'Clears cached versions of discovered handlers';
     protected $usage       = 'handlers:clear';
 
+    /**
+     * @return void
+     */
     public function run(array $params = [])
     {
         $count = cache()->deleteMatching('handlers-*');

tests/BaseFactoryTest.php

@@ -10,7 +10,7 @@
  */
 final class BaseFactoryTest extends TestCase
 {
-    public function testNoDiscoveryReturnsEmptyArray()
+    public function testNoDiscoveryReturnsEmptyArray(): void
     {
         $factory                      = new class () extends BaseFactory {
             public const HANDLER_PATH = 'Bananas';
@@ -19,7 +19,7 @@ public function testNoDiscoveryReturnsEmptyArray()
         $this->assertSame([], $factory::findAll());
     }
 
-    public function testGetHandlerClassReturnsClass()
+    public function testGetHandlerClassReturnsClass(): void
     {
         $expected = 'Tests\Support\Cars\WidgetCar';
 
@@ -29,36 +29,36 @@ public function testGetHandlerClassReturnsClass()
         $this->assertSame($expected, $result);
     }
 
-    public function testGetHandlerClassRequiresPhpExtension()
+    public function testGetHandlerClassRequiresPhpExtension(): void
     {
         $result = CarFactory::getHandlerClass('foo', 'bar');
 
         $this->assertNull($result);
     }
 
-    public function testGetHandlerClassRequiresInterfaces()
+    public function testGetHandlerClassRequiresInterfaces(): void
     {
         $result = CarFactory::getHandlerClass(SUPPORTPATH . 'Cars/NotCar.php', 'Tests\Support');
 
         $this->assertNull($result);
     }
 
-    public function testGetHandlerClassRequiresHandlerInterface()
+    public function testGetHandlerClassRequiresHandlerInterface(): void
     {
         $result = CarFactory::getHandlerClass(SUPPORTPATH . 'Cars/BadCar.php', 'Tests\Support');
 
         $this->assertNull($result);
     }
 
-    public function testGetHandlerClassFails()
+    public function testGetHandlerClassFails(): void
     {
         $file   = realpath(SUPPORTPATH . 'Cars/WidgetCar.php');
         $result = CarFactory::getHandlerClass($file, 'Foo\Bar');
 
         $this->assertNull($result);
     }
 
-    public function testIgnoresClass()
+    public function testIgnoresClass(): void
     {
         config('Handlers')->ignoredClasses[] = 'Tests\Support\Cars\PopCar';
 
@@ -68,7 +68,7 @@ public function testIgnoresClass()
         $this->assertSame($expected, $result);
     }
 
-    public function testCollision()
+    public function testCollision(): void
     {
         // Stop ignoring the collision clas
         config('Handlers')->ignoredClasses = [];
@@ -79,7 +79,7 @@ public function testCollision()
         CarFactory::findAll();
     }
 
-    public function testFindAll()
+    public function testFindAll(): void
     {
         $expected = [
             'pop'    => 'Tests\Support\Cars\PopCar',
@@ -91,7 +91,7 @@ public function testFindAll()
         $this->assertSame($expected, $result);
     }
 
-    public function testFind()
+    public function testFind(): void
     {
         $expected = 'Tests\Support\Cars\PopCar';
 
@@ -100,15 +100,15 @@ public function testFind()
         $this->assertSame($expected, $result);
     }
 
-    public function testFindThrows()
+    public function testFindThrows(): void
     {
         $this->expectException('RuntimeException');
         $this->expectExceptionMessage('Unknown handler "banana" for ' . CarFactory::class);
 
         CarFactory::find('banana');
     }
 
-    public function testResetSingle()
+    public function testResetSingle(): void
     {
         CarFactory::findAll();
         FactoryFactory::findAll();
@@ -121,7 +121,7 @@ public function testResetSingle()
         $this->assertSame(['Factories'], array_keys($result));
     }
 
-    public function testResetAll()
+    public function testResetAll(): void
     {
         CarFactory::findAll();
         FactoryFactory::findAll();

tests/CacheTest.php

@@ -15,7 +15,7 @@ protected function tearDown(): void
         CarFactory::clearCache();
     }
 
-    public function testDiscoveryUsesCache()
+    public function testDiscoveryUsesCache(): void
     {
         // Reenable caching
         config('Handlers')->cacheDuration = MINUTE;
@@ -28,7 +28,7 @@ public function testDiscoveryUsesCache()
         $this->assertSame($expected, $result); // @phpstan-ignore-line
     }
 
-    public function testDiscoveryCreatesCache()
+    public function testDiscoveryCreatesCache(): void
     {
         // Reenable caching
         config('Handlers')->cacheDuration = MINUTE;
@@ -41,7 +41,7 @@ public function testDiscoveryCreatesCache()
         $this->assertSame('Tests\Support\Cars\PopCar', $result['pop']);
     }
 
-    public function testDiscoveryIgnoresCache()
+    public function testDiscoveryIgnoresCache(): void
     {
         $expected = [
             'pop'    => 'Tests\Support\Cars\PopCar',

tests/CommandsTest.php

@@ -34,12 +34,12 @@ protected function tearDown(): void
         stream_filter_remove($this->streamFilter);
     }
 
-    protected function getBuffer()
+    protected function getBuffer(): string
     {
         return CITestStreamFilter::$buffer;
     }
 
-    public function testCacheFailsCachingDisabled()
+    public function testCacheFailsCachingDisabled(): void
     {
         config('Handlers')->cacheDuration = null;
 
@@ -48,7 +48,7 @@ public function testCacheFailsCachingDisabled()
         $this->assertStringContainsString('Handler caching is disabled by the Tatter\Handlers Config file', $this->getBuffer());
     }
 
-    public function testCacheCreatesCache()
+    public function testCacheCreatesCache(): void
     {
         command('handlers:cache');
 
@@ -61,7 +61,7 @@ public function testCacheCreatesCache()
         $this->assertSame('Tests\Support\Cars\PopCar', $result['pop']);
     }
 
-    public function testCacheReportsErrors()
+    public function testCacheReportsErrors(): void
     {
         // Stop ignoring the ErrorFactory
         unset(config('Handlers')->ignoredClasses[1]);
@@ -76,7 +76,7 @@ public function testCacheReportsErrors()
         $this->assertSame(ErrorFactory::class, $result['error']);
     }
 
-    public function testCacheErrorsNoHandlers()
+    public function testCacheErrorsNoHandlers(): void
     {
         // Ignore all Factories
         config('Handlers')->ignoredClasses = [
@@ -90,7 +90,7 @@ public function testCacheErrorsNoHandlers()
         $this->assertStringContainsString('No factories discovered!', $this->getBuffer());
     }
 
-    public function testClearRemovesCache()
+    public function testClearRemovesCache(): void
     {
         command('handlers:cache');
         $this->assertNotNull(cache()->get('handlers-factories'));

tests/FactoryFactoryTest.php

@@ -9,7 +9,7 @@
  */
 final class FactoryFactoryTest extends TestCase
 {
-    public function testDiscovers()
+    public function testDiscovers(): void
     {
         // Discovery is alphabetical by ID
         $expected = [