fix(sql): Fix QueryResult typings (#1928)

FabianLars · tweidinger · web-flow · commit 319564699638 · 2024-12-02T14:49:06.000+01:00
* fix(sql): Fix QueryResult typings closes #1893 * Create fix-sql-queryresult-type.md --------- Co-authored-by: Tillmann <28728469+tweidinger@users.noreply.github.com>
diff --git a/.changes/fix-sql-queryresult-type.md b/.changes/fix-sql-queryresult-type.md
@@ -0,0 +1,5 @@
+---
+sql-js: patch
+---
+
+Fixed the QueryResult typing by marking `lastInsertId` as optional to reflect postgres-only changes made in the 2.0.0 release.
diff --git a/plugins/sql/guest-js/index.ts b/plugins/sql/guest-js/index.ts
@@ -10,12 +10,12 @@ export interface QueryResult {
   /**
    * The last inserted `id`.
    *
-   * This value is always `0` when using the Postgres driver. If the
+   * This value is not set for Postgres databases. If the
    * last inserted id is required on Postgres, the `select` function
    * must be used, with a `RETURNING` clause
    * (`INSERT INTO todos (title) VALUES ($1) RETURNING id`).
    */
-  lastInsertId: number
+  lastInsertId?: number
 }
 
 /**

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +sql-js: patch
 +---
++
 +Fixed the QueryResult typing by marking `lastInsertId` as optional to reflect postgres-only changes made in the 2.0.0 release.
Original file line number	Diff line number	Diff line change
`@@ -10,12 +10,12 @@ export interface QueryResult {`
`10`	`10`	`/**`
`11`	`11`	* The last inserted `id`.
`12`	`12`	`*`
`13`		- * This value is always `0` when using the Postgres driver. If the
	`13`	`+ * This value is not set for Postgres databases. If the`
`14`	`14`	* last inserted id is required on Postgres, the `select` function
`15`	`15`	* must be used, with a `RETURNING` clause
`16`	`16`	* (`INSERT INTO todos (title) VALUES ($1) RETURNING id`).
`17`	`17`	`*/`
`18`		`- lastInsertId: number`
	`18`	`+ lastInsertId?: number`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`/**`