fix(positioner): handleIconState missing permission and wrong impl (#1911)

Author: lucasfernog

.changes/fix-handleIconState.md

@@ -0,0 +1,6 @@
+---
+"positioner": patch
+"positioner-js": patch
+---
+
+Added missing permission for `handleIconState` and fixed its event processing logic.

plugins/positioner/api-iife.js

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-License-Identifier: MIT
 
-const COMMANDS: &[&str] = &["move_window"];
+const COMMANDS: &[&str] = &["move_window", "set_tray_icon_state"];
 
 fn main() {
     tauri_plugin::Builder::new(COMMANDS)

plugins/positioner/build.rs

@@ -40,20 +40,8 @@ export async function moveWindow(to: Position): Promise<void> {
 }
 
 export async function handleIconState(event: TrayIconEvent): Promise<void> {
-  const size = {} as Record<string, unknown>
-  size[`${event.rect.size.type}`] = {
-    width: event.rect.size.width,
-    height: event.rect.size.height
-  }
-
-  const position = {} as Record<string, unknown>
-  position[`${event.rect.position.type}`] = {
-    x: event.rect.position.x,
-    y: event.rect.position.y
-  }
-
   await invoke('plugin:positioner|set_tray_icon_state', {
-    position,
-    size
+    position: event.rect.position,
+    size: event.rect.size
   })
 }

plugins/positioner/guest-js/index.ts

@@ -4,5 +4,10 @@
 
 [[permission]]
 identifier = "allow-set-tray-icon-state"
-description = "Enables the set_tray_icon_state to handle events and set the TrayIcon state."
+description = "Enables the set_tray_icon_state command without any pre-configured scope."
 commands.allow = ["set_tray_icon_state"]
+
+[[permission]]
+identifier = "deny-set-tray-icon-state"
+description = "Denies the set_tray_icon_state command without any pre-configured scope."
+commands.deny = ["set_tray_icon_state"]

plugins/positioner/permissions/autogenerated/commands/set_tray_icon_state.toml

@@ -1,6 +1,6 @@
 ## Default Permission
 
-Allows the move_window command
+Allows the moveWindow and handleIconState APIs
 
 - `allow-move-window`
 - `set-tray-icon-state`
@@ -48,7 +48,20 @@ Denies the move_window command without any pre-configured scope.
 </td>
 <td>
 
-Enables the set_tray_icon_state to handle events and set the TrayIcon state.
+Enables the set_tray_icon_state command without any pre-configured scope.
+
+</td>
+</tr>
+
+<tr>
+<td>
+
+`positioner:deny-set-tray-icon-state`
+
+</td>
+<td>
+
+Denies the set_tray_icon_state command without any pre-configured scope.
 
 </td>
 </tr>

plugins/positioner/permissions/autogenerated/reference.md

@@ -1,4 +1,4 @@
 "$schema" = "schemas/schema.json"
 [default]
-description = "Allows the move_window command"
+description = "Allows the moveWindow and handleIconState APIs"
 permissions = ["allow-move-window", "set-tray-icon-state"]

plugins/positioner/permissions/default.toml

@@ -305,12 +305,17 @@
           "const": "deny-move-window"
         },
         {
-          "description": "Enables the set_tray_icon_state to handle events and set the TrayIcon state.",
+          "description": "Enables the set_tray_icon_state command without any pre-configured scope.",
           "type": "string",
           "const": "allow-set-tray-icon-state"
         },
         {
-          "description": "Allows the move_window command",
+          "description": "Denies the set_tray_icon_state command without any pre-configured scope.",
+          "type": "string",
+          "const": "deny-set-tray-icon-state"
+        },
+        {
+          "description": "Allows the moveWindow and handleIconState APIs",
           "type": "string",
           "const": "default"
         }