Skip to content

Commit 69e4c2e

Browse files
fix(updater): pass /NS and /UPDATE to nsis installer to disable creating shortcuts on updates (#1162)
* fix(updater): pass `/NS` to nsis installer to disable creating shortcuts on updates ref: tauri-apps/tauri#9395 * add `/UPDATE` * move args to function * update updater test config * revert /R --------- Co-authored-by: Lucas Nogueira <[email protected]>
1 parent 7581576 commit 69e4c2e

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

.changes/updater-nsis-shortcuts.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"updater": "patch"
3+
---
4+
5+
Fix NSIS updater creating new shortcuts on update.

plugins/updater/src/updater.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -556,6 +556,8 @@ impl Update {
556556
match updater_type {
557557
WindowsUpdaterType::Nsis => {
558558
installer_args.extend(install_mode.nsis_args().iter().map(OsStr::new));
559+
installer_args.push(OsStr::new("/NS"));
560+
installer_args.push(OsStr::new("/UPDATE"));
559561
}
560562
WindowsUpdaterType::Msi => {
561563
installer_args.extend(install_mode.msiexec_args().iter().map(OsStr::new));

plugins/updater/tests/app-updater/tauri.conf.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
"icons/icon.ico"
2222
],
2323
"windows": {
24-
"wix": {
25-
"skipWebviewInstall": true
24+
"webviewInstallMode": {
25+
"type": "skip"
2626
}
2727
}
2828
}

0 commit comments

Comments
 (0)