fix(http): properly invoke abort (#1662)

twlite · amrbashir · web-flow · commit 84f8bd5e1ef2 · 2024-08-14T19:18:32.000+03:00
Co-authored-by: amrbashir &lt;github@amrbashir.me&gt;
diff --git a/.changes/fix-http-plugin-abort.md b/.changes/fix-http-plugin-abort.md
@@ -0,0 +1,5 @@
+---
+"http-js": patch
+---
+
+Fixed an issue with abort signal not aborting the fetch request.
diff --git a/plugins/http/api-iife.js b/plugins/http/api-iife.js
diff --git a/plugins/http/guest-js/index.ts b/plugins/http/guest-js/index.ts
@@ -186,7 +186,7 @@ export async function fetch(
     throw new Error(ERROR_REQUEST_CANCELLED);
   }
 
-  signal?.addEventListener("abort", () => abort);
+  signal?.addEventListener("abort", () => void abort());
 
   interface FetchSendResponse {
     status: number;

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"http-js": patch
 +---
++
 +Fixed an issue with abort signal not aborting the fetch request.
Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ export async function fetch(`
`186`	`186`	`throw new Error(ERROR_REQUEST_CANCELLED);`
`187`	`187`	`}`
`188`	`188`
`189`		`- signal?.addEventListener("abort", () => abort);`
	`189`	`+ signal?.addEventListener("abort", () => void abort());`
`190`	`190`
`191`	`191`	`interface FetchSendResponse {`
`192`	`192`	`status: number;`