fix(updater): validate endpoint scheme before printing warning (#1868)

regression from #1814

Author: lucasfernog

.changes/fix-updater-warning.md

@@ -0,0 +1,5 @@
+---
+"updater": patch
+---
+
+Fix configuration parser incorrectly warning about the endpoint scheme.

plugins/updater/src/config.rs

@@ -142,14 +142,13 @@ pub(crate) fn validate_endpoints(
 ) -> crate::Result<()> {
     if !dangerous_insecure_transport_protocol {
         for url in endpoints {
-            #[cfg(debug_assertions)]
-            #[cfg(debug_assertions)]
-            eprintln!("[\x1b[33mWARNING\x1b[0m] The updater endpoint \"{url}\" doesn't use `https` protocol. This is allowed in development but will fail in release builds.");
-            #[cfg(debug_assertions)]
-            eprintln!("[\x1b[33mWARNING\x1b[0m] if this is a desired behavior, you can enable `dangerousInsecureTransportProtocol` in the plugin configuration");
-
-            #[cfg(not(debug_assertions))]
             if url.scheme() != "https" {
+                #[cfg(debug_assertions)]
+                {
+                    eprintln!("[\x1b[33mWARNING\x1b[0m] The updater endpoint \"{url}\" doesn't use `https` protocol. This is allowed in development but will fail in release builds.");
+                    eprintln!("[\x1b[33mWARNING\x1b[0m] if this is a desired behavior, you can enable `dangerousInsecureTransportProtocol` in the plugin configuration");
+                }
+                #[cfg(not(debug_assertions))]
                 return Err(crate::Error::InsecureTransportProtocol);
             }
         }