From 8d4eb077bef4e591d16619c6f76fbd3522c6136c Mon Sep 17 00:00:00 2001 From: Tony Date: Thu, 29 Aug 2024 11:39:21 +0800 Subject: [PATCH 1/3] Don't store position on minimized --- plugins/window-state/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/window-state/src/lib.rs b/plugins/window-state/src/lib.rs index e577b45f34..a4d4e758b2 100644 --- a/plugins/window-state/src/lib.rs +++ b/plugins/window-state/src/lib.rs @@ -313,7 +313,7 @@ impl WindowExtInternal for Window { } } - if flags.contains(StateFlags::POSITION) && !is_maximized { + if flags.contains(StateFlags::POSITION) && !is_maximized && !self.is_minimized() { let position = self.outer_position()?; state.x = position.x; state.y = position.y; From 921d1a9290575904f4f1018a4aa2b85f962fecb5 Mon Sep 17 00:00:00 2001 From: Tony Date: Thu, 29 Aug 2024 11:42:19 +0800 Subject: [PATCH 2/3] Add change file --- .changes/fix-restore-minimized-window-position.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changes/fix-restore-minimized-window-position.md diff --git a/.changes/fix-restore-minimized-window-position.md b/.changes/fix-restore-minimized-window-position.md new file mode 100644 index 0000000000..37334c30ea --- /dev/null +++ b/.changes/fix-restore-minimized-window-position.md @@ -0,0 +1,5 @@ +--- +"window-state": patch +--- + +Fix saving a minimized window's state changes its position to -32000 From 1971b69231d16f5f599249b4dbfda33f06867a3d Mon Sep 17 00:00:00 2001 From: Tony Date: Thu, 29 Aug 2024 11:51:19 +0800 Subject: [PATCH 3/3] ? --- plugins/window-state/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/window-state/src/lib.rs b/plugins/window-state/src/lib.rs index a4d4e758b2..85ae7ecebf 100644 --- a/plugins/window-state/src/lib.rs +++ b/plugins/window-state/src/lib.rs @@ -313,7 +313,7 @@ impl WindowExtInternal for Window { } } - if flags.contains(StateFlags::POSITION) && !is_maximized && !self.is_minimized() { + if flags.contains(StateFlags::POSITION) && !is_maximized && !self.is_minimized()? { let position = self.outer_position()?; state.x = position.x; state.y = position.y;