feat: support message dialogs with 3 buttons #2641
Conversation
Package Changes Through 355fc91There are 4 changes which include dialog with minor, dialog-js with minor, updater with minor, updater-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
iOS is not tested ofc Windows and Android are tested and works. |
Co-authored-by: Tony <[email protected]>
|
@FabianLars or @lucasfernog can you test the iOS stuff? |
…uri-apps/plugins-workspace into feat/message-dialog-3-buttons
|
Can do but I'm kinda away over the weekend so please remind me on Monday if I or Lucas didn't get to it yet by then. |
|
don't worry about it, enjoy your weekend |
|
I started taking a look at it but got carried away to other things. I was trying to improve the return type but.. it's complicated |
plugins/dialog/guest-js/index.ts
Outdated
| export type MessageDialogButtonsYesNoCancel = { | ||
| /** The Yes button. */ | ||
| yes: string | ||
| /** The No button. */ | ||
| no: string | ||
| /** The Cancel button. */ | ||
| cancel: string | ||
| } | ||
|
|
||
| /** | ||
| * The Ok and Cancel buttons of a message dialog. | ||
| * | ||
| * @since 2.3.0 | ||
| */ | ||
| export type MessageDialogButtonsOkCancel = { | ||
| /** The Ok button. */ | ||
| ok: string | ||
| /** The Cancel button. */ | ||
| cancel: string | ||
| } | ||
|
|
||
| /** | ||
| * The Ok button of a message dialog. | ||
| * | ||
| * @since 2.3.0 | ||
| */ | ||
| export type MessageDialogButtonsOk = { | ||
| /** The Ok button. */ | ||
| ok: string | ||
| } |
There was a problem hiding this comment.
Just a small suggestion, maybe we can change these to something like this, so typescript doesn't hint ok and yes at the same type
| export type MessageDialogButtonsYesNoCancel = { | |
| /** The Yes button. */ | |
| yes: string | |
| /** The No button. */ | |
| no: string | |
| /** The Cancel button. */ | |
| cancel: string | |
| } | |
| /** | |
| * The Ok and Cancel buttons of a message dialog. | |
| * | |
| * @since 2.3.0 | |
| */ | |
| export type MessageDialogButtonsOkCancel = { | |
| /** The Ok button. */ | |
| ok: string | |
| /** The Cancel button. */ | |
| cancel: string | |
| } | |
| /** | |
| * The Ok button of a message dialog. | |
| * | |
| * @since 2.3.0 | |
| */ | |
| export type MessageDialogButtonsOk = { | |
| /** The Ok button. */ | |
| ok: string | |
| } | |
| export type MessageDialogButtonsYesNoCancel = { | |
| /** The Yes button. */ | |
| yes: string | |
| /** The No button. */ | |
| no: string | |
| /** The Cancel button. */ | |
| cancel: string | |
| } | |
| /** | |
| * The Ok and Cancel buttons of a message dialog. | |
| * | |
| * @since 2.3.0 | |
| */ | |
| export type MessageDialogButtonsOkCancel = { | |
| /** The Ok button. */ | |
| yes: string | |
| /** The Cancel button. */ | |
| cancel: string | |
| } | |
| /** | |
| * The Ok button of a message dialog. | |
| * | |
| * @since 2.3.0 | |
| */ | |
| export type MessageDialogButtonsOk = { | |
| /** The Ok button. */ | |
| yes: string | |
| } |
Can you maybe expand on that so someone else can potentially take over? |
|
i love this :D |
😂 😂 omg it took me a minute to realize wtf is this |
|
To be honest, although it's correct at the type level and it does error out if extra buttons are passed, this type makes it harder to follow to me 
instead of 
|
|
weird, i only ever got the second type of warning.. maybe we just go with the other way :| |
|
I feel like But this doesn't quite match the I feel like as long as we put some examples in |
closes #2640