Skip to content

Conversation

Keerthi421
Copy link
Contributor

Description : This PR adds sound support for desktop notifications in Tauri v2, which was previously only available on mobile platforms.

Changes:
-->Updated desktop.rs to use notify-rust's sound_name method for sound support on desktop platforms
-->Fixed Windows 7 compatibility implementation by properly enabling sound
-->Updated TypeScript API documentation to clarify how sound works across different platforms
-->Added documentation in README.md about the sound feature
-->Added an entry to CHANGELOG.md
-->Created test examples (sound-notification.js and sound-notification.html) that demonstrate the feature

Fixes #2671

@Keerthi421 Keerthi421 requested a review from a team as a code owner May 5, 2025 11:30
Copy link
Contributor

github-actions bot commented May 5, 2025

Package Changes Through 4a4d72d

There are 4 changes which include deep-link with patch, deep-link-js with patch, notification with patch, notification-js with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.33 2.0.34
api-example-js 2.0.29 2.0.30
deep-link-example-js 2.2.4 2.2.5
deep-link 2.4.1 2.4.2
deep-link-js 2.4.1 2.4.2
notification 2.3.0 2.3.1
notification-js 2.3.0 2.3.1
single-instance 2.3.2 2.3.3

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@sendy34
Copy link

sendy34 commented Jun 29, 2025

@Keerthi421 thanks for the PR. Waiting for this to be merged soon :) 👍
Notifications without sound are not very helpful.

@FabianLars
Copy link
Member

apologies if that wasn't obvious but i was waiting for the CI issues to be resolved before i'd properly review the changes.

p.s. we use changefiles (example) and don't modify the changelog manually.

lucasfernog
lucasfernog previously approved these changes Aug 21, 2025
@lucasfernog lucasfernog merged commit 2d03e2e into tauri-apps:v2 Aug 21, 2025
19 checks passed
@kieranm
Copy link

kieranm commented Sep 5, 2025

@Keerthi421

Hey! What's the correct way to bundle the sound file with the app? I've tried adding it as a resource and then using resolveResource to get the path, but no cigar (the default sound seems to play on MacOS). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No sound on desktop notifications anymore ?
5 participants