Skip to content

Conversation

lucasfernog
Copy link
Member

No description provided.

@lucasfernog lucasfernog requested a review from a team as a code owner August 24, 2025 14:29
Copy link
Contributor

github-actions bot commented Aug 24, 2025

Package Changes Through 176c5fa

There are 2 changes which include shell with patch, shell-js with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.34 2.0.35
api-example-js 2.0.30 2.0.31
shell 2.3.0 2.3.1
shell-js 2.3.0 2.3.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member

does this need to be changed too? https://github.com/tauri-apps/plugins-workspace/blob/v2/plugins/shell/src/commands.rs#L118

Also i think we have to check if it ends with .exe already before appending it i think i remember seeing people including it in the name (didn't try it myself but i think this would cause issues elsewhere so idk how valuable a check is, i just think it wouldn't hurt)

program.with_extension("").display().to_string()
} else {
program_as_string.clone()
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wish trim_suffix would be stabilized already, that would be so much nicer

@lucasfernog lucasfernog merged commit d865ed4 into v2 Aug 25, 2025
16 checks passed
@lucasfernog lucasfernog deleted the fix/sidecar-dot branch August 25, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants