Skip to content

Commit a483786

Browse files
chore(windows): downgrade eventloop warnings (#1189)
* chore(windows): downgrade warnings * Add change-file * Add TODOs
1 parent a133504 commit a483786

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

.changes/downgrade-warnings.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"tao": patch
3+
---
4+
5+
Downgrades several logs in the Windows backend from WARN to DEBUG.

src/platform_impl/windows/event_loop/runner.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,8 @@ impl<T> EventLoopRunner<T> {
208208
pub(crate) unsafe fn send_event(&self, event: Event<'_, T>) {
209209
if let Event::RedrawRequested(_) = event {
210210
if self.runner_state.get() != RunnerState::HandlingRedrawEvents {
211-
warn!("RedrawRequested dispatched without explicit MainEventsCleared");
211+
// TODO: Consider removing log once https://github.com/rust-windowing/winit/pull/2767 gets adopted.
212+
debug!("RedrawRequested dispatched without explicit MainEventsCleared");
212213
self.move_state_to(RunnerState::HandlingRedrawEvents);
213214
}
214215
self.call_event_handler(event);
@@ -342,7 +343,8 @@ impl<T> EventLoopRunner<T> {
342343
self.call_event_handler(Event::MainEventsCleared);
343344
}
344345
(HandlingMainEvents, Idle) => {
345-
warn!("RedrawEventsCleared emitted without explicit MainEventsCleared");
346+
// TODO: Consider removing log once https://github.com/rust-windowing/winit/pull/2767 gets adopted.
347+
debug!("RedrawEventsCleared emitted without explicit MainEventsCleared");
346348
self.call_event_handler(Event::MainEventsCleared);
347349
self.call_redraw_events_cleared();
348350
}
@@ -356,7 +358,8 @@ impl<T> EventLoopRunner<T> {
356358
self.call_redraw_events_cleared();
357359
}
358360
(HandlingRedrawEvents, HandlingMainEvents) => {
359-
warn!("NewEvents emitted without explicit RedrawEventsCleared");
361+
// TODO: Consider removing log once https://github.com/rust-windowing/winit/pull/2767 gets adopted.
362+
debug!("NewEvents emitted without explicit RedrawEventsCleared");
360363
self.call_redraw_events_cleared();
361364
self.call_new_events(false);
362365
}

0 commit comments

Comments
 (0)