Skip to content

Commit cd68b03

Browse files
authored
feat(ci): use trusted publishers for NPM publishing (#14874)
* feat(ci): use trusted publishers for NPM publishing * bump npm version * update npm * use empty NODE_AUTH_TOKEN * entire workflow permissions
1 parent 8d67af3 commit cd68b03

File tree

2 files changed

+10
-13
lines changed

2 files changed

+10
-13
lines changed

.github/workflows/covector-version-or-publish.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
actions: write # required for workflow_dispatch
6262
contents: write # required to create new releases
6363
pull-requests: write # required to open version update pr
64-
id-token: write # pnpm provenance
64+
id-token: write # pnpm provenance / oidc token
6565
outputs:
6666
change: ${{ steps.covector.outputs.change }}
6767
commandRan: ${{ steps.covector.outputs.commandRan }}
@@ -74,10 +74,9 @@ jobs:
7474
with:
7575
fetch-depth: 0
7676
- run: npm i -g --force corepack
77-
- uses: actions/setup-node@v4
77+
- uses: actions/setup-node@v6
7878
with:
79-
node-version: 20
80-
registry-url: 'https://registry.npmjs.org'
79+
node-version: 24
8180

8281
- name: cargo login
8382
run: cargo login ${{ secrets.ORG_CRATES_IO_TOKEN }}
@@ -95,7 +94,6 @@ jobs:
9594
uses: jbolda/covector/packages/action@covector-v0
9695
id: covector
9796
env:
98-
NODE_AUTH_TOKEN: ${{ secrets.ORG_NPM_TOKEN }}
9997
CARGO_AUDIT_OPTIONS: ${{ secrets.CARGO_AUDIT_OPTIONS }}
10098
NPM_CONFIG_PROVENANCE: true
10199
with:

.github/workflows/publish-cli-js.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ defaults:
2020
run:
2121
working-directory: packages/cli/
2222

23+
permissions:
24+
contents: write # update release
25+
id-token: write # oidc token
26+
2327
jobs:
2428
build:
2529
strategy:
@@ -366,16 +370,13 @@ jobs:
366370
- test-linux-x64-gnu-binding
367371
- test-linux-x64-musl-binding
368372
#- test-linux-arm-bindings
369-
permissions:
370-
contents: write # update release
371-
id-token: write # npm provenance
372373
steps:
373374
- uses: actions/checkout@v4
374375
- run: npm i -g --force corepack
375376
- name: Setup node
376-
uses: actions/setup-node@v4
377+
uses: actions/setup-node@v6
377378
with:
378-
node-version: 20
379+
node-version: 24
379380
cache: 'pnpm'
380381
- name: Install dependencies
381382
run: pnpm i --frozen-lockfile --ignore-scripts
@@ -390,10 +391,8 @@ jobs:
390391
shell: bash
391392
- name: Publish
392393
run: |
393-
echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" >> ~/.npmrc
394394
npm publish
395395
env:
396396
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
397-
NPM_TOKEN: ${{ secrets.ORG_NPM_TOKEN }}
397+
NODE_AUTH_TOKEN: ''
398398
RELEASE_ID: ${{ github.event.client_payload.releaseId || inputs.releaseId }}
399-
NPM_CONFIG_PROVENANCE: true

0 commit comments

Comments
 (0)