Skip to content

tauri-bundler: Inconsistent package_base_name #13893

@Andrew15-5

Description

@Andrew15-5

I can't yet compile AppImage, but I tried rpm and deb, and was surprised to see this:

name_0.1.0_amd64.deb
name-0.1.0-.x86_64.rpm
name_0.1.0_x64-setup.exe (NSIS)

These are the packages I can bundle so far, and already the naming scheme is really inconsistent.

let package_base_name = format!(
"{}_{}_{}",
settings.product_name(),
settings.version_string(),
arch
);

let package_base_name = format!("{product_name}-{version}-{release}.{arch}");

let package_base_name = format!(
"{}_{}_{}-setup",
settings.product_name(),
settings.version_string(),
arch,
);

Dioxus passes an empty release to rpm, so it got this -., which I thought was some sort of bug. I don't know why you need a separate release for rpm but not for other packages, would be nice to have Option<String> instead.

2 main issues: _ vs. -, and amd64 vs. x86_64 vs. x64 (and that is not checking the rest of the package types). Not only would it be visually hard to find the appropriate package from a list of them, but also tools like https://github.com/cargo-bins/cargo-binstall/blob/main/SUPPORT.md might trip over and not find a package that should've been matched otherwise.

Having ready-to-publish package names is something that is lacking right now. You have to rename them one way or another.

I wanted to make a quick PR, but there are too many variables/unknowns that I don't even know what should be the ideal change.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions