Skip to content

fix: add windows to target_os of TaoWindowEvent::Focused (fix #9755) #12014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kanatapple wants to merge 2 commits into from
Closed

fix: add windows to target_os of TaoWindowEvent::Focused (fix #9755) #12014

kanatapple wants to merge 2 commits into from

Conversation

@kanatapple
Copy link
Contributor

@kanatapple kanatapple commented Dec 20, 2024

closes #9755

Fixed an issue where focus events would not fire when unstable feature was enabled in Windows.

@kanatapple kanatapple requested a review from a team as a code owner December 20, 2024 04:58
@xuchaoqian xuchaoqian mentioned this pull request Jan 2, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited
Loading

Package Changes Through 70a5cf7

There are 8 changes which include @tauri-apps/api with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.1.1 2.2.0
tauri-utils 2.1.0 2.1.1
tauri-bundler 2.1.0 2.2.0
tauri-runtime 2.2.0 2.3.0
tauri-runtime-wry 2.2.0 2.3.0
tauri-codegen 2.0.3 2.0.4
tauri-macros 2.0.3 2.0.4
tauri-plugin 2.0.3 2.0.4
tauri-build 2.0.3 2.0.4
tauri 2.1.1 2.2.0
@tauri-apps/cli 2.1.0 2.2.0
tauri-cli 2.1.0 2.2.0

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

FabianLars
FabianLars reviewed Jan 2, 2025
View reviewed changes
@FabianLars
Copy link
Member

FabianLars commented Jan 2, 2025

Came here because of #11659 (comment) (cc @xuchaoqian). Unfortunetely i can't merge this yet (sorry for the useless commit). First if you have the unstable flag enabled your PR will print true and false on focus toggle unless you only click on the titlebar instead of the webview itself. This may be better than the current behavior of no event at all, but sadly it slightly breaks the Focused event if you don't have the unstable feature flag enabled, then it will emit the events twice.

@FabianLars FabianLars marked this pull request as draft January 2, 2025 10:10
@kanatapple
Copy link
Contributor Author

kanatapple commented Jan 8, 2025

@FabianLars
I apologize for the lack of confirmation.
It seems that I need to understand the core more to solve this problem... 😅

lucasfernog added a commit that referenced this pull request Apr 13, 2025
@lucasfernog
fix(tauri-runtime-wry): send focused events on multiwebview for Windows
3ce3318 
closes #9755

follow-up for #12014
@lucasfernog lucasfernog mentioned this pull request Apr 13, 2025
Merged
@lucasfernog
Copy link
Member

lucasfernog commented Apr 13, 2025

the complete solution is a bit more complicated, see #13222
thanks for the contribution though! you were in the right path :)

lucasfernog added a commit that referenced this pull request Apr 14, 2025
@lucasfernog
fix(tauri-runtime-wry): send focused events on multiwebview for Windo…
07953fb 
…ws (#13222)

* fix(tauri-runtime-wry): send focused events on multiwebview for Windows

closes #9755

follow-up for #12014

* fix mobile build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FabianLars FabianLars FabianLars left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug] tauri does not deliver WindowEvent::Focused when unstable feature is enabled

3 participants

@kanatapple @FabianLars @lucasfernog