Skip to content

Conversation

@Tunglies
Copy link
Contributor

No description provided.

@Tunglies Tunglies requested a review from a team as a code owner November 16, 2025 07:05
@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap Nov 16, 2025
@Tunglies
Copy link
Contributor Author

Perhaps we could consider adding Clippy rules to the repo?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2025

Package Changes Through 49a2671

There are 6 changes which include @tauri-apps/api with patch, tauri with patch, tauri-cli with patch, tauri-bundler with patch, @tauri-apps/cli with patch, tauri-macos-sign with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.9.0 2.9.1
tauri-macos-sign 2.3.0 2.3.1
tauri-bundler 2.7.3 2.7.4
tauri 2.9.3 2.9.4
@tauri-apps/cli 2.9.4 2.9.5
tauri-cli 2.9.4 2.9.5

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member

Perhaps we could consider adding Clippy rules to the repo?

What do you have in mind? pedantic used to be too much

@Tunglies
Copy link
Contributor Author

Perhaps we could consider adding Clippy rules to the repo?

What do you have in mind? pedantic used to be too much

Maybe we can try nursery rules first, e.g. clippy::significant_drop_tightening and clippy::or_fun_call. pedantic rules producing some noise, but helps in over all so we can try avoid expensive performance operations.

@Tunglies
Copy link
Contributor Author

The issue in #14476, where an unwrap causes a panic, could be avoided by enabling the Clippy rule clippy::unwrap_used with warn or deny.

@FabianLars FabianLars merged commit ee3cc4a into tauri-apps:dev Nov 17, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from 📬Proposal to 🔎 In audit in Roadmap Nov 17, 2025
@Tunglies
Copy link
Contributor Author

Perhaps we could consider adding Clippy rules to the repo?

What do you have in mind? pedantic used to be too much

I lost FabianLars, too much .expect and .unwarp uses XD

@FabianLars
Copy link
Member

yeah, the cli (and its subcrates) is quite heavy on that but since it's a cli it's more or less alright. the tauri runtime crates would be more important but even that has many unwraps :/

@Tunglies
Copy link
Contributor Author

yeah, the cli (and its subcrates) is quite heavy on that but since it's a cli it's more or less alright. the tauri runtime crates would be more important but even that has many unwraps :/

I heared that recently Cloudflare gets 500 Internal server error due to ONE line rust unwarp operation. LOL

@FabianLars
Copy link
Member

luckily we're not cloudflare right? 😂 Though it sounds like that unwrap wasn't really the cause but just the end of a chain of errors though using expect should have been the bare minimum if you can't or don't want to propagate the error up

@FabianLars
Copy link
Member

same for us of course, most unwraps should be replaced with expect even if that results in larger file size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

2 participants