-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
perf: remove needless clones in various files for improved performance #14475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: remove needless clones in various files for improved performance #14475
Conversation
|
Perhaps we could consider adding Clippy rules to the repo? |
Package Changes Through 49a2671There are 6 changes which include @tauri-apps/api with patch, tauri with patch, tauri-cli with patch, tauri-bundler with patch, @tauri-apps/cli with patch, tauri-macos-sign with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
What do you have in mind? |
Maybe we can try |
|
The issue in #14476, where an unwrap causes a panic, could be avoided by enabling the Clippy rule clippy::unwrap_used with warn or deny. |
I lost FabianLars, too much .expect and .unwarp uses XD |
|
yeah, the cli (and its subcrates) is quite heavy on that but since it's a cli it's more or less alright. the tauri runtime crates would be more important but even that has many unwraps :/ |
I heared that recently Cloudflare gets 500 Internal server error due to ONE line rust unwarp operation. LOL |
|
luckily we're not cloudflare right? 😂 Though it sounds like that unwrap wasn't really the cause but just the end of a chain of errors though using |
|
same for us of course, most unwraps should be replaced with expect even if that results in larger file size |
No description provided.