fix(macos): webview_version crash if com.apple.WebKit is not found (#1609)

Author: lucasfernog

.changes/fix-macos-webview-version-crash.md

@@ -0,0 +1,5 @@
+---
+"wry": patch
+---
+
+Enhance error handling of the `webview_version` function on macOS.

src/wkwebview/mod.rs

@@ -1260,12 +1260,33 @@ pub fn url_from_webview(webview: &WKWebView) -> Result<String> {
 
 pub fn platform_webview_version() -> Result<String> {
   unsafe {
-    let bundle = NSBundle::bundleWithIdentifier(&NSString::from_str("com.apple.WebKit")).unwrap();
-    let dict = bundle.infoDictionary().unwrap();
-    let webkit_version = dict
-      .objectForKey(&NSString::from_str("CFBundleVersion"))
-      .unwrap();
-    let webkit_version = webkit_version.downcast::<NSString>().unwrap();
+    let Some(bundle) = NSBundle::bundleWithIdentifier(&NSString::from_str("com.apple.WebKit"))
+    else {
+      return Err(Error::Io(std::io::Error::new(
+        std::io::ErrorKind::Other,
+        "failed to locate com.apple.WebKit bundle",
+      )));
+    };
+    let Some(dict) = bundle.infoDictionary() else {
+      return Err(Error::Io(std::io::Error::new(
+        std::io::ErrorKind::Other,
+        "failed to get WebKit info dictionary",
+      )));
+    };
+
+    let Some(webkit_version) = dict.objectForKey(&NSString::from_str("CFBundleVersion")) else {
+      return Err(Error::Io(std::io::Error::new(
+        std::io::ErrorKind::Other,
+        "failed to get WebKit version",
+      )));
+    };
+
+    let Ok(webkit_version) = webkit_version.downcast::<NSString>() else {
+      return Err(Error::Io(std::io::Error::new(
+        std::io::ErrorKind::Other,
+        "failed to parse WebKit version",
+      )));
+    };
 
     bundle.unload();
     Ok(webkit_version.to_string())