Skip to content

Commit 24a627f

Browse files
committed
Add review guidelines
Extends committee membership information with guidance on what is expected of committee members.
1 parent 27a9931 commit 24a627f

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

doc/src/general-rules.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,3 +92,18 @@ members = [
9292
+ "rahulku"
9393
]
9494
```
95+
96+
Committee members are expected to contribute by reviewing pull requests (all
97+
pull requests review approvals from at least two committee members before they
98+
can be merged).
99+
Reviews of solutions towards challenges should consider at least the following aspects:
100+
101+
1. Does the pull request implement a solution that respects/meets the success
102+
criteria of the challenge?
103+
2. Do the contracts and harnesses incorporate the safety conditions stated in
104+
the documentation (from comments in the code and Rust book)? Note that we
105+
currently focus on safety verification. Pre- and post-conditions towards
106+
functional correctness are acceptable as long as they do not negatively
107+
impact verification of safety, such as over-constraining input values.
108+
3. Is the contributed code of adequate quality and idiomatic (to the best of the
109+
committee member's knowledge).

0 commit comments

Comments
 (0)