Revert "Auto merge of rust-lang#89709 - clemenswasser:apply_clippy_suggestions_2, r=petrochenkov"

matthiaskrgr · matthiaskrgr · commit 4dc68f328719 · 2021-10-15T11:28:23.000+02:00
The PR had some unforseen perf regressions that are not as easy to find. Revert the PR for now. This reverts commit 6ae8912, reversing changes made to 86d6d2b.
diff --git a/core/src/num/fmt.rs b/core/src/num/fmt.rs
@@ -31,10 +31,8 @@ impl<'a> Part<'a> {
                     } else {
                         3
                     }
-                } else if v < 10_000 {
-                    4
                 } else {
-                    5
+                    if v < 10_000 { 4 } else { 5 }
                 }
             }
             Part::Copy(buf) => buf.len(),

Original file line number	Diff line number	Diff line change
`@@ -31,10 +31,8 @@ impl<'a> Part<'a> {`
`31`	`31`	`} else {`
`32`	`32`	`3`
`33`	`33`	`}`
`34`		`- } else if v < 10_000 {`
`35`		`- 4`
`36`	`34`	`} else {`
`37`		`- 5`
	`35`	`+ if v < 10_000 { 4 } else { 5 }`
`38`	`36`	`}`
`39`	`37`	`}`
`40`	`38`	`Part::Copy(buf) => buf.len(),`