Upgrading PHPWord?

[radarhere]

59573f8 effectively patched phpoffice.

I don't know exactly what code was run to require the change, but I would hope that changes to the vendored packages can be minimised in the long run.

Regarding the return type, I've created PHPOffice/PHPWord#2776 to suggest adding that to PHPWord.

Regarding the null change, if I'm reproducing the same problem you are, then I think the cause of the issue is actually

jethro-pmm/vendor/phpoffice/phpword/src/PhpWord/Writer/Word2007/Style/Cell.php

Line 51 in da3f74c

$xmlWriter->writeAttribute('w:w', $this->width);

which writes the width without checking if it is null or not.

A check for this became part of PHPWord in 0.14 - https://github.com/PHPOffice/PHPWord/blob/0.14.0/src/PhpWord/Writer/Word2007/Style/Cell.php#L48-L55

Jethro uses 0.13

jethro-pmm/composer.json

Line 3 in da3f74c

"phpoffice/phpword": "v0.13.*",

I understand you may not wish to upgrade to the latest version of PHPWord because you wish to continue supporting PHP 5.3, but is there any reason not to upgrade to 0.18.3? PHP 5.3.3 is still supported - see https://packagist.org/packages/phpoffice/phpword#0.18.3

[tbar0970]

Thanks for that. Agree about ideally avoiding patching vendored packages. PHPWord upgrade seems wise.

[radarhere]

I've created #1210 to upgrade to PHPWord 0.18.0.

As perhaps a more general question, is there any point in time at which you would be comfortable increasing the minimum required PHP version for Jethro? It's been 10 years since PHP 5.3 support ended, and 6 years since PHP 7.0 support ended. Something like https://stitcher.io/blog/php-version-stats-january-2025 doesn't even list those versions since they are below 1% usage.

[tbar0970]

Thanks, I've merged the PR.

You're right - it's time to lift the requirement to PHP 7+.
In some cases vendors such as RedHat provided extended support for PHP versions that were officially EOL - this was the case for 5.3 for some time - so I wanted Jethro to be compatible with those environments. But the 5.3 era is definitely past.

[radarhere]

Thanks