Skip to content

Commit 784be8c

Browse files
committed
Fix nits
1 parent e16220e commit 784be8c

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

flang/test/Integration/OpenMP/parallel-private-reduction-worstcase.f90

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
! RUN: %flang_fc1 -fopenmp -emit-llvm %s -o - | FileCheck %s
22

3-
! stress test cfg and builder insertion points in mlir-to-llvm conversion:
3+
! Compinational testing of control flow graph and builder insertion points
4+
! in mlir-to-llvm conversion:
45
! - mixing multiple delayed privatisations and multiple reductions
56
! - multiple blocks in the private alloc region
67
! - private alloc region has to read from the mold variable

mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -371,8 +371,8 @@ convertOmpCritical(Operation &opInst, llvm::IRBuilderBase &builder,
371371
return success();
372372
}
373373

374-
// Looks up from the operation from and returns the PrivateClauseOp with
375-
// name symbolName
374+
/// Looks up from the operation from and returns the PrivateClauseOp with
375+
/// name symbolName
376376
static omp::PrivateClauseOp findPrivatizer(Operation *from,
377377
SymbolRefAttr symbolName) {
378378
omp::PrivateClauseOp privatizer =
@@ -382,7 +382,7 @@ static omp::PrivateClauseOp findPrivatizer(Operation *from,
382382
return privatizer;
383383
}
384384

385-
/// Populates `privatizations` with privatisation declarations used for the
385+
/// Populates `privatizations` with privatization declarations used for the
386386
/// given op.
387387
/// TODO: generalise beyond ParallelOp
388388
static void collectPrivatizationDecls(
@@ -1356,7 +1356,7 @@ convertOmpParallel(omp::ParallelOp opInst, llvm::IRBuilderBase &builder,
13561356
LogicalResult bodyGenStatus = success();
13571357
llvm::OpenMPIRBuilder *ompBuilder = moduleTranslation.getOpenMPBuilder();
13581358

1359-
// Collect delayed privatisation declarations
1359+
// Collect delayed privatization declarations
13601360
MutableArrayRef<BlockArgument> privateBlockArgs =
13611361
cast<omp::BlockArgOpenMPOpInterface>(*opInst).getPrivateBlockArgs();
13621362
SmallVector<llvm::Value *> llvmPrivateVars;

0 commit comments

Comments
 (0)