Improve assertions for aggregation unit tests

Author: tbolier

test/integration/Aggregation/AvgTest.php

@@ -14,62 +14,18 @@ class AvgTest extends AbstractTableTest
      */
     public function testAvg(): void
     {
-        $this->insertDocument(5);
-        $this->insertDocument(4);
-        $this->insertDocument(3);
-        $this->insertDocument(2);
-        $this->insertDocument(1);
+        $this->insertDocumentWithNumber(5, 5);
+        $this->insertDocumentWithNumber(4, 10);
+        $this->insertDocumentWithNumber(3, 15);
+        $this->insertDocumentWithNumber(2, 20);
+        $this->insertDocumentWithNumber(1, 25);
 
         /** @var ResponseInterface $res */
         $res = $this->r()
             ->table('tabletest')
             ->avg('number')
             ->run();
 
-        $this->assertTrue(is_float($res->getData()) || is_int($res->getData()));
-    }
-
-    /**
-     * @return void
-     * @throws \Exception
-     */
-    public function testFilterAndAvg(): void
-    {
-        $this->insertDocument(5);
-        $this->insertDocument(4);
-        $this->insertDocument(3);
-        $this->insertDocument(2);
-        $this->insertDocument(1);
-
-        /** @var ResponseInterface $res */
-        $res = $this->r()
-                    ->table('tabletest')
-                    ->filter(['description' => 'A document description.'])
-                    ->avg('number')
-                    ->run();
-
-        $this->assertTrue(is_float($res->getData()) || is_int($res->getData()));
-    }
-
-    /**
-     * @return void
-     * @throws \Exception
-     */
-    public function testGetAllAndAvg(): void
-    {
-        $this->insertDocument(5);
-        $this->insertDocument(4);
-        $this->insertDocument(3);
-        $this->insertDocument(2);
-        $this->insertDocument(1);
-
-        /** @var ResponseInterface $res */
-        $res = $this->r()
-                    ->table('tabletest')
-                    ->getAll(1, 2, 3, 4, 5)
-                    ->avg('number')
-                    ->run();
-
-        $this->assertTrue(is_float($res->getData()) || is_int($res->getData()));
+        $this->assertEquals(15, $res->getData());
     }
 }

test/integration/Aggregation/CountTest.php

@@ -13,76 +13,17 @@ class CountTest extends AbstractTableTest
      */
     public function testCount()
     {
-        $this->insertDocument(1);
+        $this->insertDocumentWithNumber(5, 5);
+        $this->insertDocumentWithNumber(4, 10);
+        $this->insertDocumentWithNumber(3, 15);
+        $this->insertDocumentWithNumber(2, 20);
+        $this->insertDocumentWithNumber(1, 25);
 
         $res = $this->r()
             ->table('tabletest')
             ->count()
             ->run();
 
-        $this->assertInternalType('int', $res->getData());
-    }
-
-    /**
-     * @throws \Exception
-     */
-    public function testGetAllAndCount()
-    {
-        $this->insertDocument(1);
-        $this->insertDocument(2);
-        $this->insertDocument(3);
-        $this->insertDocument(4);
-        $this->insertDocument(5);
-
-        /** @var ResponseInterface $res */
-        $res = $this->r()
-                    ->table('tabletest')
-                    ->getAll(1, 2, 3, 4, 5)
-                    ->count()
-                    ->run();
-
-        $this->assertEquals(5, $res->getData());
-    }
-
-    /**
-     * @throws \Exception
-     */
-    public function testFilterAndCount()
-    {
-        $this->insertDocument(1);
-        $this->insertDocument(2);
-        $this->insertDocument(3);
-        $this->insertDocument(4);
-        $this->insertDocument(5);
-
-        /** @var ResponseInterface $res */
-        $res = $this->r()
-            ->table('tabletest')
-            ->filter(['id' => 1])
-            ->count()
-            ->run();
-
-        $this->assertEquals(1, $res->getData());
-    }
-
-    /**
-     * @throws \Exception
-     */
-    public function testFilterAndCountMultiple()
-    {
-        $this->insertDocument(1);
-        $this->insertDocument(2);
-        $this->insertDocument(3);
-        $this->insertDocument(4);
-        $this->insertDocument(5);
-
-        /** @var ResponseInterface $res */
-        $res = $this->r()
-            ->table('tabletest')
-            ->filter(['description' => 'A document description.'])
-            ->count()
-            ->run();
-
         $this->assertEquals(5, $res->getData());
     }
 }

test/integration/Aggregation/SumTest.php

@@ -14,62 +14,18 @@ class SumTest extends AbstractTableTest
      */
     public function testSum(): void
     {
-        $this->insertDocument(5);
-        $this->insertDocument(4);
-        $this->insertDocument(3);
-        $this->insertDocument(2);
-        $this->insertDocument(1);
+        $this->insertDocumentWithNumber(5, 5);
+        $this->insertDocumentWithNumber(4, 10);
+        $this->insertDocumentWithNumber(3, 15);
+        $this->insertDocumentWithNumber(2, 20);
+        $this->insertDocumentWithNumber(1, 25);
 
         /** @var ResponseInterface $res */
         $res = $this->r()
             ->table('tabletest')
             ->sum('number')
             ->run();
 
-        $this->assertInternalType('int', $res->getData());
-    }
-
-    /**
-     * @return void
-     * @throws \Exception
-     */
-    public function testFilterAndSum(): void
-    {
-        $this->insertDocument(5);
-        $this->insertDocument(4);
-        $this->insertDocument(3);
-        $this->insertDocument(2);
-        $this->insertDocument(1);
-
-        /** @var ResponseInterface $res */
-        $res = $this->r()
-                    ->table('tabletest')
-                    ->filter(['description' => 'A document description.'])
-                    ->sum('number')
-                    ->run();
-
-        $this->assertInternalType('int', $res->getData());
-    }
-
-    /**
-     * @return void
-     * @throws \Exception
-     */
-    public function testGetAllAndSum(): void
-    {
-        $this->insertDocument(5);
-        $this->insertDocument(4);
-        $this->insertDocument(3);
-        $this->insertDocument(2);
-        $this->insertDocument(1);
-
-        /** @var ResponseInterface $res */
-        $res = $this->r()
-                    ->table('tabletest')
-                    ->getAll(1, 2, 3, 4, 5)
-                    ->sum('number')
-                    ->run();
-
-        $this->assertInternalType('int', $res->getData());
+        $this->assertEquals(75, $res->getData());
     }
 }