fix: Extract buildSpecs to reduce run() cyclomatic complexity, fix gofmt

Author: lykinsbd

cissh.go

@@ -28,6 +28,50 @@ type listenerSpec struct {
 	sequence []utils.SequenceStep // nil for platform-only listeners
 }
 
+func resolveListeners(cli utils.CLI, tm utils.TranscriptMap, baseDir string) ([]listenerSpec, error) {
+	if cli.Inventory == "" {
+		fd, err := fakedevices.InitGeneric(cli.Platform, tm, baseDir)
+		if err != nil {
+			return nil, err
+		}
+		var specs []listenerSpec
+		for port := cli.StartingPort; port < cli.StartingPort+cli.Listeners; port++ {
+			specs = append(specs, listenerSpec{fd, port, nil})
+		}
+		return specs, nil
+	}
+
+	inv, err := utils.LoadInventory(cli.Inventory)
+	if err != nil {
+		return nil, err
+	}
+
+	var specs []listenerSpec
+	port := cli.StartingPort
+	for _, entry := range inv.Devices {
+		if entry.Scenario != "" {
+			fd, seq, err := fakedevices.InitScenario(entry.Scenario, tm, baseDir)
+			if err != nil {
+				return nil, err
+			}
+			for i := 0; i < entry.Count; i++ {
+				specs = append(specs, listenerSpec{fd, port, seq})
+				port++
+			}
+		} else {
+			fd, err := fakedevices.InitGeneric(entry.Platform, tm, baseDir)
+			if err != nil {
+				return nil, err
+			}
+			for i := 0; i < entry.Count; i++ {
+				specs = append(specs, listenerSpec{fd, port, nil})
+				port++
+			}
+		}
+	}
+	return specs, nil
+}
+
 func run(ctx context.Context, cli utils.CLI) error {
 	myTranscriptMap, err := utils.LoadTranscriptMap(cli.TranscriptMap)
 	if err != nil {
@@ -39,43 +83,9 @@ func run(ctx context.Context, cli utils.CLI) error {
 		return err
 	}
 
-	var specs []listenerSpec
-
-	if cli.Inventory != "" {
-		inv, err := utils.LoadInventory(cli.Inventory)
-		if err != nil {
-			return err
-		}
-		port := cli.StartingPort
-		for _, entry := range inv.Devices {
-			if entry.Scenario != "" {
-				fd, seq, err := fakedevices.InitScenario(entry.Scenario, myTranscriptMap, baseDir)
-				if err != nil {
-					return err
-				}
-				for i := 0; i < entry.Count; i++ {
-					specs = append(specs, listenerSpec{fd, port, seq})
-					port++
-				}
-			} else {
-				fd, err := fakedevices.InitGeneric(entry.Platform, myTranscriptMap, baseDir)
-				if err != nil {
-					return err
-				}
-				for i := 0; i < entry.Count; i++ {
-					specs = append(specs, listenerSpec{fd, port, nil})
-					port++
-				}
-			}
-		}
-	} else {
-		fd, err := fakedevices.InitGeneric(cli.Platform, myTranscriptMap, baseDir)
-		if err != nil {
-			return err
-		}
-		for port := cli.StartingPort; port < cli.StartingPort+cli.Listeners; port++ {
-			specs = append(specs, listenerSpec{fd, port, nil})
-		}
+	specs, err := resolveListeners(cli, myTranscriptMap, baseDir)
+	if err != nil {
+		return err
 	}
 
 	var wg sync.WaitGroup

ssh_server/handlers/ciscohandlers_test.go

@@ -400,9 +400,9 @@ func TestHandler_ScenarioSequence(t *testing.T) {
 
 	// All three steps in a single session — pointer advances across commands
 	out := interact(t, addr, []string{
-		"show running-config",          // step 0 → "config before"
+		"show running-config",            // step 0 → "config before"
 		"interface GigabitEthernet0/0/2", // step 1 → ""
-		"show running-config",          // step 2 → "config after"
+		"show running-config",            // step 2 → "config after"
 	})
 	if !strings.Contains(out, "config before") {
 		t.Errorf("expected 'config before' in output, got:\n%s", out)