Skip to content

Commit d11f2e9

Browse files
authored
Merge pull request #65 from tbphp/refactor-stream-response
refactor: 优化流式响应的性能和兼容性
2 parents 7b06d83 + 655b67e commit d11f2e9

File tree

1 file changed

+14
-22
lines changed

1 file changed

+14
-22
lines changed

internal/proxy/response_handlers.go

Lines changed: 14 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
package proxy
22

33
import (
4-
"bufio"
5-
"net/http"
6-
74
"io"
5+
"net/http"
86

97
"github.com/gin-gonic/gin"
108
"github.com/sirupsen/logrus"
@@ -23,29 +21,23 @@ func (ps *ProxyServer) handleStreamingResponse(c *gin.Context, resp *http.Respon
2321
return
2422
}
2523

26-
scanner := bufio.NewScanner(resp.Body)
27-
scanner.Buffer(make([]byte, 0, 64*1024), 1024*1024)
28-
for scanner.Scan() {
29-
select {
30-
case <-c.Request.Context().Done():
31-
logrus.Debugf("Client disconnected, closing stream.")
32-
return
33-
default:
24+
buf := make([]byte, 4*1024)
25+
for {
26+
n, err := resp.Body.Read(buf)
27+
if n > 0 {
28+
if _, writeErr := c.Writer.Write(buf[:n]); writeErr != nil {
29+
logUpstreamError("writing stream to client", writeErr)
30+
return
31+
}
32+
flusher.Flush()
3433
}
35-
36-
if _, err := c.Writer.Write(scanner.Bytes()); err != nil {
37-
logUpstreamError("writing stream to client", err)
38-
return
34+
if err == io.EOF {
35+
break
3936
}
40-
if _, err := c.Writer.Write([]byte("\n")); err != nil {
41-
logUpstreamError("writing stream newline to client", err)
37+
if err != nil {
38+
logUpstreamError("reading from upstream", err)
4239
return
4340
}
44-
flusher.Flush()
45-
}
46-
47-
if err := scanner.Err(); err != nil {
48-
logUpstreamError("reading from upstream scanner", err)
4941
}
5042
}
5143

0 commit comments

Comments
 (0)