Rework annotation processing and dependencies in IT tests

Even if included only for annotations, don't mark dependencies
as provided or optional, following best practices: they can be
needed by static analysis tools downstream (like ErrorProne).

Move annotation processor to annotationProcessorPaths in
maven-compiler-plugin.
By simplicity, include it in all modules in E2E test, even if
not needed everywhere.

Author: tbroyer

src/it/e2e/e2e-client/pom.xml

@@ -32,19 +32,9 @@
       <artifactId>guava-gwt</artifactId>
       <scope>provided</scope>
     </dependency>
-    <dependency>
-      <groupId>com.google.auto.value</groupId>
-      <artifactId>auto-value</artifactId>
-      <!-- This is only need at compile-time, there's no runtime dependency -->
-      <scope>provided</scope>
-      <optional>true</optional>
-    </dependency>
     <dependency>
       <groupId>com.google.auto.value</groupId>
       <artifactId>auto-value-annotations</artifactId>
-      <!-- This is only need at compile-time, there's no runtime dependency -->
-      <scope>provided</scope>
-      <optional>true</optional>
     </dependency>
   </dependencies>
 

src/it/e2e/e2e-model/pom.xml

@@ -20,23 +20,10 @@
     <dependency>
       <groupId>com.google.guava</groupId>
       <artifactId>guava</artifactId>
-      <!-- We only use it for annotations, so we only need it at compile-time -->
-      <scope>provided</scope>
-      <optional>true</optional>
-    </dependency>
-    <dependency>
-      <groupId>com.google.auto.value</groupId>
-      <artifactId>auto-value</artifactId>
-      <!-- This is only need at compile-time, there's no runtime dependency -->
-      <scope>provided</scope>
-      <optional>true</optional>
     </dependency>
     <dependency>
       <groupId>com.google.auto.value</groupId>
       <artifactId>auto-value-annotations</artifactId>
-      <!-- This is only need at compile-time, there's no runtime dependency -->
-      <scope>provided</scope>
-      <optional>true</optional>
     </dependency>
   </dependencies>
   <build>

src/it/e2e/pom.xml

@@ -33,11 +33,6 @@
         <version>2.5</version>
         <scope>provided</scope>
       </dependency>
-      <dependency>
-        <groupId>com.google.auto.value</groupId>
-        <artifactId>auto-value</artifactId>
-        <version>1.9</version>
-      </dependency>
       <dependency>
         <groupId>com.google.auto.value</groupId>
         <artifactId>auto-value-annotations</artifactId>
@@ -66,6 +61,13 @@
           <configuration>
             <source>1.7</source>
             <target>1.7</target>
+            <annotationProcessorPaths>
+              <path>
+                <groupId>com.google.auto.value</groupId>
+                <artifactId>auto-value</artifactId>
+                <version>1.9</version>
+              </path>
+            </annotationProcessorPaths>
           </configuration>
         </plugin>
         <plugin>

src/it/gwt-app/pom.xml

@@ -31,25 +31,11 @@
       <groupId>com.google.guava</groupId>
       <artifactId>guava-gwt</artifactId>
       <version>31.1-jre</version>
-      <!-- We only use it for annotations, so we only need it at compile-time -->
-      <scope>provided</scope>
-      <optional>true</optional>
-    </dependency>
-    <dependency>
-      <groupId>com.google.auto.value</groupId>
-      <artifactId>auto-value</artifactId>
-      <version>1.9</version>
-      <!-- This is only need at compile-time, there's no runtime dependency -->
-      <scope>provided</scope>
-      <optional>true</optional>
     </dependency>
     <dependency>
       <groupId>com.google.auto.value</groupId>
       <artifactId>auto-value-annotations</artifactId>
       <version>1.9</version>
-      <!-- This is only need at compile-time, there's no runtime dependency -->
-      <scope>provided</scope>
-      <optional>true</optional>
     </dependency>
     <dependency>
       <groupId>junit</groupId>
@@ -85,6 +71,13 @@
           <configuration>
             <source>1.7</source>
             <target>1.7</target>
+            <annotationProcessorPaths>
+              <path>
+                <groupId>com.google.auto.value</groupId>
+                <artifactId>auto-value</artifactId>
+                <version>1.9</version>
+              </path>
+            </annotationProcessorPaths>
           </configuration>
         </plugin>
       </plugins>

src/it/gwt-lib/pom.xml

@@ -31,25 +31,11 @@
       <groupId>com.google.guava</groupId>
       <artifactId>guava-gwt</artifactId>
       <version>31.1-jre</version>
-      <!-- We only use it for annotations, so we only need it at compile-time -->
-      <scope>provided</scope>
-      <optional>true</optional>
-    </dependency>
-    <dependency>
-      <groupId>com.google.auto.value</groupId>
-      <artifactId>auto-value</artifactId>
-      <version>1.9</version>
-      <!-- This is only need at compile-time, there's no runtime dependency -->
-      <scope>provided</scope>
-      <optional>true</optional>
     </dependency>
     <dependency>
       <groupId>com.google.auto.value</groupId>
       <artifactId>auto-value-annotations</artifactId>
       <version>1.9</version>
-      <!-- This is only need at compile-time, there's no runtime dependency -->
-      <scope>provided</scope>
-      <optional>true</optional>
     </dependency>
     <dependency>
       <groupId>junit</groupId>
@@ -82,6 +68,13 @@
           <configuration>
             <source>1.7</source>
             <target>1.7</target>
+            <annotationProcessorPaths>
+              <path>
+                <groupId>com.google.auto.value</groupId>
+                <artifactId>auto-value</artifactId>
+                <version>1.9</version>
+              </path>
+            </annotationProcessorPaths>
           </configuration>
         </plugin>
       </plugins>