This repository was archived by the owner on Jan 26, 2022. It is now read-only.
Remove the minNum and maxNum functions. #345
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion in #341. These two functions were added to correspond with the IEEE 754 functions of the same name. However, since EcmaScript doesn't distinguish quiet and signaling NaNs, it is non-trivial to achieve the exact same behavior as the IEEE functions. The SIMD.js min() and max() functions remain. They have the same behavior as Math.min() and Math.max().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #341.
These two functions were added to correspond with the IEEE 754 functions of the
same name. However, since EcmaScript doesn't distinguish quiet and signaling
NaNs, it is non-trivial to achieve the exact same behavior as the IEEE
functions.
The SIMD.js min() and max() functions remain. They have the same behavior as
Math.min() and Math.max().