✅ account for punctuation in linebreak check

Author: ctcpip

scripts/bad-linebreaks-test.mjs

@@ -7,28 +7,28 @@ const afterMD = './scripts/test-samples/bad-linebreaks-sample-after.md';
 const beforeMD = './scripts/test-samples/bad-linebreaks-sample-before.md';
 
 // verify hash values to detect file tampering
-const knownAfterHash = '5f29c1fb4abd747c2dd801e12c600ee3';
-const knownBeforeHash = '406e900af5cd9af66abbe5b3ab6bcf3e';
-const afterHash = await getHashSlingingSlasher(afterMD);
+const knownBeforeHash = '5dfa7a6c97c43bf3321f2e9ccafd3ce8';
+const knownAfterHash = '9ed9cc827a7ffa71e6c243a23d7e24a3';
 const beforeHash = await getHashSlingingSlasher(beforeMD);
-assert.strictEqual(afterHash, knownAfterHash);
+const afterHash = await getHashSlingingSlasher(afterMD);
 assert.strictEqual(beforeHash, knownBeforeHash);
+assert.strictEqual(afterHash, knownAfterHash);
 
 let fixed, totalMatches;
 
 ({ fixed, totalMatches } = findBadStuff(beforeMD, true));
-assert.strictEqual(totalMatches.badLinebreaks, 12);
-assert.strictEqual(totalMatches.extraWhitespace, 114);
-assert.strictEqual(fixed, fs.readFileSync(afterMD, 'utf8').toString());
+assert.strictEqual(totalMatches.badLinebreaks, 44);
+assert.strictEqual(totalMatches.extraWhitespace, 131);
+validateLines(fixed, fs.readFileSync(afterMD, 'utf8').toString());
 
 ({ fixed, totalMatches } = findBadStuff(afterMD, true));
 assert.strictEqual(totalMatches.badLinebreaks, 0);
 assert.strictEqual(totalMatches.extraWhitespace, 0);
-assert.strictEqual(fixed, fs.readFileSync(afterMD, 'utf8').toString());
+validateLines(fixed, fs.readFileSync(afterMD, 'utf8').toString());
 
 ({ fixed, totalMatches } = findBadStuff(beforeMD));
-assert.strictEqual(totalMatches.badLinebreaks, 12);
-assert.strictEqual(totalMatches.extraWhitespace, 114);
+assert.strictEqual(totalMatches.badLinebreaks, 44);
+assert.strictEqual(totalMatches.extraWhitespace, 131);
 
 function getHashSlingingSlasher(file) {  // 💀
   return new Promise((res, rej) => {
@@ -39,3 +39,16 @@ function getHashSlingingSlasher(file) {  // 💀
     stream.on('end', () => res(hash.digest('hex')));
   });
 }
+
+function validateLines(actual, expected) {
+
+  const expectedLines = expected.split('\n');
+  const actualLines = actual.split('\n');
+
+  for (let i = 0; i < expectedLines.length; i++) {
+    const eLine = expectedLines[i];
+    const aLine = actualLines[i];
+    assert.strictEqual(aLine, eLine);
+  }
+
+}

scripts/bad-linebreaks.mjs

@@ -14,7 +14,7 @@ const tokenTypeEnum = Object.freeze({
   SPACE: 'space',
 });
 
-const reBadLinebreaks = /(?<=[\w\d ])\n(?=[\w\d ])/g;
+const reBadLinebreaks = /(?<=[\w\d \p{P}])\n(?=[\w\d ])/gu;
 const reExtraWhitespaceParagraph = /^ +| (?= )| +$/gm;
 const reExtraWhitespaceList = /(?<=^ {0,}[-*+] |\d+\. ) +|(?<=\w+ ) +| +$/gm;
 

scripts/test-samples/bad-linebreaks-sample-after.md

@@ -13,9 +13,7 @@ BBB: This is a sentence.
 
 CCC: This is a sentence with trailing spaces.
 
-CCC: This is a sentence.
-DDD: This is also a sentence.
-EEE: Hmmmmmm.
+CCC: This is a sentence. DDD: This is also a sentence. EEE: Hmmmmmm.
 
 ```
 here be code
@@ -53,6 +51,10 @@ let biscuits = "delicious";
   * one more
   + time
 
+RPR: thanks especially to Roderigo for helping out to arrange that meeting. We can see you in the room, Roderigo. Thank you. All right. So on to the usual items. So let’s start, let’s see if we have approval for last -- actually, I don’t think we fully committed them yet, so we should probably -- let’s return to that perhaps later in the meeting once we’ve got that. All right, what about the current agenda? Are there any objections to the current agenda? And I will say because I’m working on a laptop, I cannot see the element room right now. If any of the other chairs do see anything, please just interrupt. I’m going to take silence as approval. I will say with today’s current agenda, or this week’s current agenda, it is packed. It is oversubscribed. You’ll see that we have many really good items in the overflow slot at the moment. We’re going to work you know, we’re going to do our best to claw some back. Maybe some people will consider deprioritizing items. I know I’ve already heard some some candidates there that we may do. But the main thing is we need to really work hard to keep -- to do food time keeping and stick to our time boxes. And with that, I think I can hand over to Samina.
+
+RPR: thanks especially to Roderigo for helping out to arrange that meeting. We can see you in the room, Roderigo. Thank you. All right. So on to the usual items. So let’s start, let’s see if we have approval for last -- actually, I don’t think we fully committed them yet, so we should probably -- let’s return to that perhaps later in the meeting once we’ve got that. All right, what about the current agenda? Are there any objections to the current agenda? And I will say because I’m working on a laptop, I cannot see the element room right now. If any of the other chairs do see anything, please just interrupt. I’m going to take silence as approval. I will say with today’s current agenda, or this week’s current agenda, it is packed. It is oversubscribed. You’ll see that we have many really good items in the overflow slot at the moment. We’re going to work you know, we’re going to do our best to claw some back. Maybe some people will consider deprioritizing items. I know I’ve already heard some some candidates there that we may do. But the main thing is we need to really work hard to keep -- to do food time keeping and stick to our time boxes. And with that, I think I can hand over to Samina.
+
 ## story time!
 
 True! nervous, very, very dreadfully nervous I had been and am; but why will you say that I am mad? The disease had sharpened my senses, not destroyed, not dulled them. Above all was the sense of hearing acute. I heard all things in the heaven and in the earth. I heard many things in hell. How then am I mad? Hearken! and observe how healthily, how calmly I can tell you the whole story.
@@ -75,19 +77,15 @@ It was open, wide, wide open, and I grew furious as I gazed upon it. I saw it wi
 
 And now have I not told you that what you mistake for madness is but over-acuteness of the senses? now, I say, there came to my ears a low, dull, quick sound, such as a watch makes when enveloped in cotton. I knew that sound well, too. It was the beating of the old man's heart. It increased my fury, as the beating of a drum stimulates the soldier into courage.
 
-But even yet I refrained and kept still. I scarcely breathed. I held the lantern motionless. I tried how steadily I could maintain the ray upon the eye. Meantime the hellish tattoo of the heart increased. It grew quicker and quicker, and louder and louder, every instant. The old man's terror must have been extreme! It grew louder, I say, louder every moment!—do you mark me well? I have told you that I am nervous: so I am. And now at the dead hour of the night, amid the dreadful silence of that old house, so strange a noise as this excited me to uncontrollable terror. Yet, for some minutes longer I refrained and stood still. But the beating grew louder, louder! I thought the heart must burst. And now a new anxiety seized me—the sound would be heard by a neighbor!
-The old man's hour had come! With a loud yell, I threw open the lantern and leaped into the room. He shrieked once—once only. In an instant I dragged him to the floor, and pulled the heavy bed over him. I then smiled gaily, to find the deed so far done. But for many minutes the heart beat on with a muffled sound. This, however, did not vex me; it would not be heard through the wall. At length it ceased. The old man was dead. I removed the bed and examined the corpse.
-Yes, he was stone, stone dead. I placed my hand upon the heart and held it there many minutes.
-There was no pulsation. He was stone dead. His eye would trouble me no more.
+But even yet I refrained and kept still. I scarcely breathed. I held the lantern motionless. I tried how steadily I could maintain the ray upon the eye. Meantime the hellish tattoo of the heart increased. It grew quicker and quicker, and louder and louder, every instant. The old man's terror must have been extreme! It grew louder, I say, louder every moment!—do you mark me well? I have told you that I am nervous: so I am. And now at the dead hour of the night, amid the dreadful silence of that old house, so strange a noise as this excited me to uncontrollable terror. Yet, for some minutes longer I refrained and stood still. But the beating grew louder, louder! I thought the heart must burst. And now a new anxiety seized me—the sound would be heard by a neighbor! The old man's hour had come! With a loud yell, I threw open the lantern and leaped into the room. He shrieked once—once only. In an instant I dragged him to the floor, and pulled the heavy bed over him. I then smiled gaily, to find the deed so far done. But for many minutes the heart beat on with a muffled sound. This, however, did not vex me; it would not be heard through the wall. At length it ceased. The old man was dead. I removed the bed and examined the corpse. Yes, he was stone, stone dead. I placed my hand upon the heart and held it there many minutes. There was no pulsation. He was stone dead. His eye would trouble me no more.
 
 If still you think me mad, you will think so no longer when I describe the wise precautions I took for the concealment of the body. The night waned, and I worked hastily, but in silence.
 
 I took up three planks from the flooring of the chamber, and deposited all between the scantlings. I then replaced the boards so cleverly, so cunningly, that no human eye—not even his—could have detected anything wrong. There was nothing to wash out—no stain of any kind—no bloodspot whatever. I had been too wary for that.
 
 When I had made an end of these labors, it was four o'clock—still dark as midnight. As the bell sounded the hour, there came a knocking at the street door. I went down to open it with a light heart—for what had I now to fear? There entered three men, who introduced themselves, with perfect suavity, as officers of the police. A shriek had been heard by a neighbor during the night; suspicion of foul play had been aroused; information had been lodged at the police office, and they (the officers) had been deputed to search the premises.
 
-I smiled—for what had I to fear? I bade the gentlemen welcome. The shriek, I said, was my own in a dream. The old man, I mentioned, was absent in the country. I took my visitors all over the house. I bade them search—search well. I led them, at length, to his chamber.
-I showed them his treasures, secure, undisturbed. In the enthusiasm of my confidence, I brought chairs into the room, and desired them here to rest from their fatigues, while I myself, in the wild audacity of my perfect triumph, placed my own seat upon the very spot beneath which reposed the corpse of the victim.
+I smiled—for what had I to fear? I bade the gentlemen welcome. The shriek, I said, was my own in a dream. The old man, I mentioned, was absent in the country. I took my visitors all over the house. I bade them search—search well. I led them, at length, to his chamber. I showed them his treasures, secure, undisturbed. In the enthusiasm of my confidence, I brought chairs into the room, and desired them here to rest from their fatigues, while I myself, in the wild audacity of my perfect triumph, placed my own seat upon the very spot beneath which reposed the corpse of the victim.
 
 The officers were satisfied. My manner had convinced them. I was singularly at ease. They sat, and while I answered cheerily, they chatted of familiar things. But, ere long, I felt myself getting pale and wished them gone. My head ached, and I fancied a ringing in my ears; but still they sat, and still chatted. The ringing became more distinct;—it continued and became more distinct. I talked more freely to get rid of the feeling, but it continued and gained definitiveness—until, at length, I found that the noise was not within my ears.
 

scripts/test-samples/bad-linebreaks-sample-before.md

@@ -59,6 +59,36 @@ let biscuits = "delicious";
   *     one   more       
   +     time  
 
+RPR: thanks especially to Roderigo for helping out to arrange that meeting. We can see you 
+in the room, Roderigo. Thank you. All right. So on to the usual items. So let’s start, 
+let’s see if we have approval for last -- actually, I don’t think we fully committed them yet, 
+so we should probably -- let’s return to that perhaps later in the meeting once we’ve got that. 
+All right, what about the current agenda?  Are there any objections to the current agenda?  And 
+I will say because I’m working on a laptop, I cannot see the element room right now. If any of 
+the other chairs do see anything, please just interrupt. I’m going to take silence as 
+approval. I will say with today’s current agenda, or this week’s current agenda, it is packed. 
+It is oversubscribed. You’ll see that we have many really good items in the overflow slot at 
+the moment. We’re going to work you know, we’re going to do our best to claw some back. 
+Maybe some people will consider deprioritizing items. I know I’ve already heard some some 
+candidates there that we may do. But the main thing is we need to really work hard to keep -- 
+to do food time keeping and stick to our time boxes. And with that, I think I can hand over to 
+Samina.
+
+RPR: thanks especially to Roderigo for helping out to arrange that meeting. We can see you
+in the room, Roderigo. Thank you. All right. So on to the usual items. So let’s start,
+let’s see if we have approval for last -- actually, I don’t think we fully committed them yet,
+so we should probably -- let’s return to that perhaps later in the meeting once we’ve got that.
+All right, what about the current agenda?  Are there any objections to the current agenda?  And
+I will say because I’m working on a laptop, I cannot see the element room right now. If any of
+the other chairs do see anything, please just interrupt. I’m going to take silence as
+approval. I will say with today’s current agenda, or this week’s current agenda, it is packed.
+It is oversubscribed. You’ll see that we have many really good items in the overflow slot at
+the moment. We’re going to work you know, we’re going to do our best to claw some back.
+Maybe some people will consider deprioritizing items. I know I’ve already heard some some
+candidates there that we may do. But the main thing is we need to really work hard to keep --
+to do food time keeping and stick to our time boxes. And with that, I think I can hand over to
+Samina.
+
 ## story time!
 
 True! nervous, very, very dreadfully nervous I had been and am; but why will you say that I am mad? The disease had sharpened my senses,  not destroyed,