🚨 Linty McLintface

Author: ctcpip

.eslintrc.js

@@ -0,0 +1,15 @@
+module.exports = {
+  root: true,
+  extends: ["eslint:recommended"],
+  parserOptions: {
+    ecmaVersion: "latest",
+    sourceType: "module",
+  },
+  env: {
+    es6: true,
+    node: true,
+  },
+  rules: {
+    "arrow-spacing": "error",
+  },
+};

.github/workflows/check.yml

@@ -13,5 +13,6 @@ jobs:
         name: 'nvm install lts/* && npm ci'
         with:
           node-version: lts/*
+      - run: npm run lint
       - run: npm run test
       - run: npm run check

.npmrc

@@ -0,0 +1 @@
+package-lock=false

.nvmrc

@@ -2,6 +2,11 @@
   "private": true,
   "scripts": {
     "check": "node -e 'import(\"./scripts/check-delegates.mjs\").then(cd => cd.checkDelegates())'",
-    "test": "node ./scripts/check-delegates-test.mjs"
+    "test": "node ./scripts/check-delegates-test.mjs",
+    "lint": "eslint . --ext .js --ext .mjs --ext .cjs",
+    "lint:fix": "eslint . --ext .js --ext .mjs --ext .cjs --fix"
+  },
+  "devDependencies": {
+    "eslint": "^8.41.0"
   }
 }

package.json

@@ -9,11 +9,11 @@ const threeLetter = `Chris de Almeida (CDA)\nRob Palmer (ROBPALMER)\nUjjwal Shar
 const duplicate = `Chris de Almeida (CDA)\nRob Palmer (RPR)\nUjjwal Sharma (USA)\nUjjwal Sharma (USA)`;
 const valid = `Chris de Almeida (CDA)\nRob Palmer (RPR)\nUjjwal Sharma (USA)`;
 
-assert.throws(()=>checkDelegates(lex), { message: /Not in lexicographic order/});
-assert.throws(()=>checkDelegates(missing), { message: /Missing abbreviation for/});
-assert.throws(()=>checkDelegates(uppercaseLatin), { message: /Abbreviations must be all uppercase Latin letters/});
-assert.throws(()=>checkDelegates(twoLetter), { message: /not in allowlist. New delegate abbreviations must be three letters/});
-assert.throws(()=>checkDelegates(threeLetter), { message: /New delegate abbreviations must be three letters/});
-assert.throws(()=>checkDelegates(duplicate), { message: /Conflicting usage on line/});
+assert.throws(() => checkDelegates(lex), { message: /Not in lexicographic order/});
+assert.throws(() => checkDelegates(missing), { message: /Missing abbreviation for/});
+assert.throws(() => checkDelegates(uppercaseLatin), { message: /Abbreviations must be all uppercase Latin letters/});
+assert.throws(() => checkDelegates(twoLetter), { message: /not in allowlist. New delegate abbreviations must be three letters/});
+assert.throws(() => checkDelegates(threeLetter), { message: /New delegate abbreviations must be three letters/});
+assert.throws(() => checkDelegates(duplicate), { message: /Conflicting usage on line/});
 
-assert.doesNotThrow(()=>checkDelegates(valid));
+assert.doesNotThrow(() => checkDelegates(valid));

scripts/check-delegates-test.mjs

@@ -30,7 +30,7 @@ export function checkDelegates(contents = fs.readFileSync('./delegates.txt', 'ut
   for (const line of lines) {
     if (line.length === 0) continue;
     const match = re.exec(line);
-    const {name, abbr} = match.groups;
+    const {abbr} = match.groups;
 
     if (previousLine.localeCompare(line, 'en') > 0) {
       throw new Error(`Line ${lineNumber}: Not in lexicographic order.`);