Skip to content

Commit e42eea9

Browse files
sffcgibson042
andauthored
Apply suggestions from code review
Co-authored-by: Richard Gibson <[email protected]>
1 parent 09a2390 commit e42eea9

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

spec/abstractops.html

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -557,8 +557,7 @@ <h1>
557557
</dl>
558558
<p>Both singular and plural unit names are accepted, but only the singular form is used internally.</p>
559559
<emu-alg>
560-
1. Let _allowedStrings_ be a new empty List.
561-
1. Append *"auto"* to _allowedStrings_.
560+
1. Let _allowedStrings_ be « *"auto"* ».
562561
1. For each row of <emu-xref href="#table-temporal-units"></emu-xref>, except the header row, in table order, do
563562
1. Let _singularName_ be the value in the "Singular property name" column of the row.
564563
1. Append _singularName_ to _allowedStrings_.
@@ -589,14 +588,11 @@ <h1>
589588
<dd>It validates that the result of GetTemporalUnitValuedOption is <emu-not-ref>covered</emu-not-ref> by the union of _unitGroup_ and _extraValues_.</dd>
590589
</dl>
591590
<emu-alg>
592-
1. Let _allowedValues_ be a new empty List.
593-
1. For each row of <emu-xref href="#table-temporal-units"></emu-xref>, except the header row, in table order, do
594-
1. Let _unit_ be the value in the "Value" column of the row.
595-
1. If the "Category" column of the row is ~date~ and _unitGroup_ is ~date~ or ~datetime~, append _unit_ to _allowedValues_.
596-
1. Else if the "Category" column of the row is ~time~ and _unitGroup_ is ~time~ or ~datetime~, append _unit_ to _allowedValues_.
597-
1. If _extraValues_ is present, then
598-
1. Set _allowedValues_ to the list-concatenation of _allowedValues_ and _extraValues_.
599-
1. If _allowedValues_ does not contain _value_, throw a RangeError exception.
591+
1. If _extraValues_ is present and _extraValues_ contains _value_, return ~unused~.
592+
1. Let _category_ be the value in the “Category” column of the row of <emu-xref href="#table-temporal-units"></emu-xref> whose “Value” column contains _value_. If there is no such row, throw a RangeError exception.
593+
1. If _category_ is ~date~ and _unitGroup_ is ~date~ or ~datetime~, return ~unused~.
594+
1. If _category_ is ~time~ and _unitGroup_ is ~time~ or ~datetime~, return ~unused~.
595+
1. Throw a RangeError exception.
600596
</emu-alg>
601597
</emu-clause>
602598

0 commit comments

Comments
 (0)