Editorial: Rename UnbalanceDateDurationRelative to DateDurationDays

This operation used to do more than just calculate the number of days, and
the name used to make more sense when we had BalanceRelative, etc. Now
it's just confusing. Rename it to reflect what it does.

See: #2953

Author: ptomato

polyfill/lib/duration.mjs

@@ -420,8 +420,8 @@ export class Duration {
       if (!plainRelativeTo) {
         throw new RangeErrorCtor('A starting point is required for years, months, or weeks comparison');
       }
-      d1 = ES.UnbalanceDateDurationRelative(duration1.date, plainRelativeTo);
-      d2 = ES.UnbalanceDateDurationRelative(duration2.date, plainRelativeTo);
+      d1 = ES.DateDurationDays(duration1.date, plainRelativeTo);
+      d2 = ES.DateDurationDays(duration2.date, plainRelativeTo);
     }
     const norm1 = duration1.norm.add24HourDays(d1);
     const norm2 = duration2.norm.add24HourDays(d2);

polyfill/lib/ecmascript.mjs

@@ -2685,7 +2685,7 @@ export function BalanceTime(hour, minute, second, millisecond, microsecond, nano
   return { deltaDays, hour, minute, second, millisecond, microsecond, nanosecond };
 }
 
-export function UnbalanceDateDurationRelative(dateDuration, plainRelativeTo) {
+export function DateDurationDays(dateDuration, plainRelativeTo) {
   const yearsMonthsWeeksDuration = AdjustDateDurationRecord(dateDuration, 0);
   if (DateDurationSign(yearsMonthsWeeksDuration) === 0) return dateDuration.days;
 

spec/duration.html

@@ -105,8 +105,8 @@ <h1>Temporal.Duration.compare ( _one_, _two_ [ , _options_ ] )</h1>
           1. Return *+0*<sub>𝔽</sub>.
         1. If IsCalendarUnit(_largestUnit1_) is *true* or IsCalendarUnit(_largestUnit2_) is *true*, then
           1. If _plainRelativeTo_ is *undefined*, throw a *RangeError* exception.
-          1. Let _days1_ be ? UnbalanceDateDurationRelative(_duration1_.[[Date]], _plainRelativeTo_).
-          1. Let _days2_ be ? UnbalanceDateDurationRelative(_duration2_.[[Date]], _plainRelativeTo_).
+          1. Let _days1_ be ? DateDurationDays(_duration1_.[[Date]], _plainRelativeTo_).
+          1. Let _days2_ be ? DateDurationDays(_duration2_.[[Date]], _plainRelativeTo_).
         1. Else,
           1. Let _days1_ be _one_.[[Days]].
           1. Let _days2_ be _two_.[[Days]].
@@ -1557,9 +1557,9 @@ <h1>ZeroTimeDuration ( ): a Normalized Time Duration Record</h1>
       </emu-alg>
     </emu-clause>
 
-    <emu-clause id="sec-temporal-unbalancedatedurationrelative" type="abstract operation">
+    <emu-clause id="sec-temporal-datedurationdays" type="abstract operation">
       <h1>
-        UnbalanceDateDurationRelative (
+        DateDurationDays (
           _dateDuration_: a Date Duration Record,
           _plainRelativeTo_: a Temporal.PlainDate,
         ): either a normal completion containing an integer or a throw completion