Merge branch 'main' into merge-and-extract-calendar-number-and-wrong-type-tests

Author: brageh01

.circleci/config.yml

@@ -68,15 +68,6 @@ jobs:
       hostPath: spidermonkey
       hostName: spidermonkey
     <<: [*execution_steps]
-  # "ChakraCore: New or modified tests execution":
-  #   docker:
-  #     - image: *node_image
-  #   working_directory: ~/test262
-  #   environment:
-  #     hostType: ch
-  #     hostPath: chakra
-  #     hostName: chakra
-  #   <<: [*execution_steps]
   "JSC: New or modified tests execution":
     docker:
       - image: *node_image
@@ -110,7 +101,6 @@ workflows:
   version: 2
   Tests execution:
     jobs:
-      # - "ChakraCore: New or modified tests execution"
       - "JSC: New or modified tests execution"
       - "SpiderMonkey: New or modified tests execution"
       - "V8: New or modified tests execution"

.github/workflows/checks.yml

@@ -50,8 +50,11 @@ jobs:
       - name: Create annotations in the PR
         if: failure() && github.event_name == 'pull_request'
         run: |
-          awk -F': ' <errors.out \
-            "{ sub(\"$(pwd)/\", \"\"); printf \"::error file=%s,line=1::%s\n\", \$1, \$2 }"
+          awk -v cwd="$(pwd)/" <errors.out '{
+            if (index($0, cwd)==1) $0=substr($0, length(cwd)+1);
+            i=index($0, ": ");
+            printf "::error file=%s,line=1::%s\n", substr($0, 1, i-1), substr($0, i+2);
+          }'
 
 
   build:

CONTRIBUTING.md

@@ -299,8 +299,8 @@ function Test262Error(message) {
 
 The [Module section of INTERPRETING.md](https://github.com/tc39/test262/blob/HEAD/INTERPRETING.md#modules) states that `_FIXTURE` files will not have Realm modifications applied. In practice, this means that code in `_FIXTURE` files must abide by the following rules:
 
-- **MUST NOT** refer to, or make use of any [Test262-Defined Bindings](https://github.com/tc39/test262/blob/HEAD/INTERPRETING.md#test262-defined-bindings) in any way. 
-- **MUST NOT** refer to, or make use of any [Host-Defined Functions](https://github.com/tc39/test262/blob/HEAD/INTERPRETING.md#host-defined-functions) in any way. 
+- **MUST NOT** refer to, or make use of any [Test262-Defined Bindings](https://github.com/tc39/test262/blob/HEAD/INTERPRETING.md#test262-defined-bindings) in any way.
+- **MUST NOT** refer to, or make use of any [Host-Defined Functions](https://github.com/tc39/test262/blob/HEAD/INTERPRETING.md#host-defined-functions) in any way.
 
 ## Handling Errors and Negative Test Cases
 
@@ -458,14 +458,14 @@ Tests expressed with this convention are built automatically following the sourc
 
 ## Reporting Bugs to Implementers
 
-- [ChakraCore](https://github.com/microsoft/ChakraCore/issues/new)
+- [Boa](https://github.com/boa-dev/boa/issues/new)
+- [ChakraCore](https://github.com/chakra-core/ChakraCore/issues/new)
 - [engine262](https://github.com/engine262/engine262/issues/new)
 - [GraalJS](https://github.com/oracle/graal/issues/new?labels=bug&template=5_issues_other.md&title=)
 - [Hermes](https://github.com/facebook/hermes/issues/new?labels%5B%5D=need+triage&labels%5B%5D=bug&template=01_bug_report.md&title=)
 - [JavaScriptCore](https://bugs.webkit.org/enter_bug.cgi?product=WebKit&component=JavaScriptCore)
+- [Kiesel](https://codeberg.org/kiesel-js/kiesel/issues/new)
 - [Moddable XS](https://github.com/Moddable-OpenSource/moddable/issues/new?assignees=&labels=&template=bug_report.md&title=)
 - [QuickJS](https://github.com/bellard/quickjs/issues/new)
 - [SpiderMonkey](https://bugzilla.mozilla.org/enter_bug.cgi?product=Core&component=JavaScript%20Engine)
 - [V8](https://bugs.chromium.org/p/v8/issues/entry)
-
-

INTERPRETING.md

@@ -71,13 +71,13 @@ properties of the global scope prior to test execution.
   - **`IsHTMLDDA`** - (present only in implementations that can provide it) an
     object that:
 
-    1. has an [[IsHTMLDDA]] internal slot, and 
-    2. when called with no arguments or with the first argument `""` (an empty string) returns `null`. 
+    1. has an [[IsHTMLDDA]] internal slot, and
+    2. when called with no arguments or with the first argument `""` (an empty string) returns `null`.
+
+          Note: The peculiar second requirement permits testing algorithms when they also call `document.all` with such arguments, so that testing for correct behavior requires knowing how the call behaves. This is rarely necessary.
 
-          Note: The peculiar second requirement permits testing algorithms when they also call `document.all` with such arguments, so that testing for correct behavior requires knowing how the call behaves. This is rarely necessary.  
-    
           Use this property to test that ECMAScript algorithms aren't mis-implemented to treat `document.all` as being `undefined` or of type Undefined (instead of Object).
-    
+
           **Tests using this function must be tagged with the `IsHTMLDDA` feature so that only hosts supporting this property will run them.**
   - **`agent`** - an ordinary object with the following properties:
     - **`start`** - a function that takes a script source string and runs
@@ -98,10 +98,10 @@ properties of the global scope prior to test execution.
       - **`leaving`** - a function that signals that the agent is done and
         may be terminated (if possible).
       - **`monotonicNow`** - a function that returns a value that conforms to [`DOMHighResTimeStamp`][] and is produced in such a way that its semantics conform to **[Monotonic Clock][]**.
-    - **`broadcast`** - a function that takes a SharedArrayBuffer and an 
-        Int32 or BigInt and broadcasts the two values to all concurrent 
-        agents. The function blocks until all agents have retrieved the 
-        message. Note, this assumes that all agents that were started are 
+    - **`broadcast`** - a function that takes a SharedArrayBuffer and an
+        Int32 or BigInt and broadcasts the two values to all concurrent
+        agents. The function blocks until all agents have retrieved the
+        message. Note, this assumes that all agents that were started are
         still running.
     - **`getReport`** - a function that reads an incoming string from any agent,
       and returns it if it exists, or returns `null` otherwise.
@@ -208,15 +208,15 @@ an exception, or if the name of the thrown exception's constructor does not
 match the specified constructor name, or if the error occurs at a phase that
 differs from the indicated phase, the test must be interpreted as "failing."
 
-The **`$DONOTEVALUATE()`** function is for use in tests that include the following meta data: 
+The **`$DONOTEVALUATE()`** function is for use in tests that include the following meta data:
 
 ```
 negative:
   phase: runtime
   type: ReferenceError
 ```
 
-The definition is considered "runner implementation defined" and no guarantees can be made about its behavior, therefore it is restricted to only tests that meet the criteria described above. 
+The definition is considered "runner implementation defined" and no guarantees can be made about its behavior, therefore it is restricted to only tests that meet the criteria described above.
 
 *Examples:*
 
@@ -258,8 +258,11 @@ export {} from './instn-resolve-empty-export_FIXTURE.js';
 ### `includes`
 
 One or more files whose content must be evaluated in the test realm's global
-scope prior to test execution. These files are located within the `harness/`
-directory of the Test262 project.
+scope prior to test execution, after the files listed in the
+[Test262-Defined Bindings](#test262-defined-bindings) section and the file
+listed for the `async` flag below.
+They must be included in the order given in the source.
+These files are located within the `harness/` directory of the Test262 project.
 
 *Example*
 
@@ -348,9 +351,11 @@ following strings:
   ```
 
 - **`async`** The file `harness/doneprintHandle.js` must be evaluated in the
-  test realm's global scope prior to test execution. The test must not be
-  considered complete until the implementation-defined `print` function has
-  been invoked or some length of time has passed without any such invocation.
+  test realm's global scope prior to test execution, after the files listed in
+  the [Test262-Defined Bindings](#test262-defined-bindings) section.
+  The test must not be considered complete until the implementation-defined
+  `print` function has been invoked or some length of time has passed without
+  any such invocation.
   In the event of a passing test run, this function will be invoked with the
   string `'Test262:AsyncTestComplete'`. If invoked with a string that is
   prefixed with the character sequence `Test262:AsyncTestFailure:`, the test

README.md

@@ -42,7 +42,7 @@ This project offers an explanation for many of its design decisions and maintena
 
 Volunteer-maintained projects that may be used to execute Test262 in various ECMAScript hosts:
 
-- https://github.com/bterlson/test262-harness (platform: Node.js)
+- https://github.com/tc39/test262-harness (platform: Node.js)
 - https://github.com/test262-utils/test262-harness-py (platform: Python)
 - https://bakkot.github.io/test262-web-runner/ (platform: web)
 - https://github.com/Izhido/test262_harness_cpp (platform: C++)

harness/hidden-constructors.js

@@ -3,7 +3,7 @@
 /*---
 description: |
     An Array of all representable Well-Known Intrinsic Objects
-defines: [WellKnownIntrinsicObjects]
+defines: [WellKnownIntrinsicObjects, getWellKnownIntrinsicObject]
 ---*/
 
 const WellKnownIntrinsicObjects = [
@@ -24,16 +24,21 @@ const WellKnownIntrinsicObjects = [
     source: 'Object.getPrototypeOf([][Symbol.iterator]())',
   },
   {
+    // Not currently accessible to ECMAScript user code
     name: '%AsyncFromSyncIteratorPrototype%',
-    source: 'undefined',
+    source: '',
   },
   {
     name: '%AsyncFunction%',
     source: '(async function() {}).constructor',
   },
   {
     name: '%AsyncGeneratorFunction%',
-    source: 'Object.getPrototypeOf(async function * () {})',
+    source: '(async function* () {}).constructor',
+  },
+  {
+    name: '%AsyncGeneratorPrototype%',
+    source: 'Object.getPrototypeOf(async function* () {}).prototype',
   },
   {
     name: '%AsyncIteratorPrototype%',
@@ -108,6 +113,7 @@ const WellKnownIntrinsicObjects = [
     source: 'Float64Array',
   },
   {
+    // Not currently accessible to ECMAScript user code
     name: '%ForInIteratorPrototype%',
     source: '',
   },
@@ -117,7 +123,11 @@ const WellKnownIntrinsicObjects = [
   },
   {
     name: '%GeneratorFunction%',
-    source: 'Object.getPrototypeOf(function * () {})',
+    source: '(function* () {}).constructor',
+  },
+  {
+    name: '%GeneratorPrototype%',
+    source: 'Object.getPrototypeOf(function * () {}).prototype',
   },
   {
     name: '%Int8Array%',
@@ -140,8 +150,12 @@ const WellKnownIntrinsicObjects = [
     source: 'isNaN',
   },
   {
-    name: '%IteratorPrototype%',
-    source: 'Object.getPrototypeOf(Object.getPrototypeOf([][Symbol.iterator]()))',
+    name: '%Iterator%',
+    source: 'typeof Iterator !== "undefined" ? Iterator : Object.getPrototypeOf(Object.getPrototypeOf([][Symbol.iterator]())).constructor',
+  },
+  {
+    name: '%IteratorHelperPrototype%',
+    source: 'Object.getPrototypeOf(Iterator.from([]).drop(0))',
   },
   {
     name: '%JSON%',
@@ -275,6 +289,10 @@ const WellKnownIntrinsicObjects = [
     name: '%WeakSet%',
     source: 'WeakSet',
   },
+  {
+    name: '%WrapForValidIteratorPrototype%',
+    source: 'Object.getPrototypeOf(Iterator.from({ [Symbol.iterator](){ return {}; } }))',
+  },
 ];
 
 WellKnownIntrinsicObjects.forEach((wkio) => {
@@ -288,3 +306,22 @@ WellKnownIntrinsicObjects.forEach((wkio) => {
 
   wkio.value = actual;
 });
+
+/**
+ * Returns a well-known intrinsic object, if the implementation provides it.
+ * Otherwise, throws.
+ * @param {string} key - the specification's name for the intrinsic, for example
+ *   "%Array%"
+ * @returns {object} the well-known intrinsic object.
+ */
+function getWellKnownIntrinsicObject(key) {
+  for (var ix = 0; ix < WellKnownIntrinsicObjects.length; ix++) {
+    if (WellKnownIntrinsicObjects[ix].name === key) {
+      var value = WellKnownIntrinsicObjects[ix].value;
+      if (value !== undefined)
+        return value;
+      throw new Test262Error('this implementation could not obtain ' + key);
+    }
+  }
+  throw new Test262Error('unknown well-known intrinsic ' + key);
+}

harness/wellKnownIntrinsicObjects.js

@@ -20,10 +20,9 @@
     "ci": "./tools/scripts/ci_test.sh",
     "test": "test262-harness",
     "diff": "git diff --diff-filter ACMR --name-only main.. -- test/ && git ls-files --exclude-standard --others -- test/",
-    "test:diff": "npm run test:diff:v8 && npm run test:diff:spidermonkey && npm run test:diff:chakra && npm run test:diff:javascriptcore",
+    "test:diff": "npm run test:diff:v8 && npm run test:diff:spidermonkey && npm run test:diff:javascriptcore",
     "test:diff:v8": "test262-harness -t 8 --hostType=d8 --hostPath=v8 $(npm run --silent diff)",
     "test:diff:spidermonkey": "test262-harness -t 8 --hostType=jsshell --hostPath=spidermonkey $(npm run --silent diff)",
-    "test:diff:chakra": "test262-harness -t 8 --hostType=ch --hostPath=chakra $(npm run --silent diff)",
     "test:diff:javascriptcore": "test262-harness -t 8 --hostType=jsc --hostPath=javascriptcore $(npm run --silent diff)",
     "test:diff:xs": "test262-harness -t 8 --hostType=xs --hostPath=xs $(npm run --silent diff)"
   }

package.json

@@ -15,10 +15,10 @@ info: |
   If Type(argument) is not Object, return false.
   If argument has a [[Construct]] internal method, return true.
   Return false.
-includes: [isConstructor.js, hidden-constructors.js]
+includes: [isConstructor.js, wellKnownIntrinsicObjects.js]
 features: [Reflect.construct]
 ---*/
 
+var AsyncFunction = getWellKnownIntrinsicObject('%AsyncFunction%');
 assert.sameValue(isConstructor(AsyncFunction), true, 'isConstructor(AsyncFunction) must return true');
 new AsyncFunction();
-  

test/built-ins/AsyncFunction/is-a-constructor.js

@@ -15,14 +15,14 @@ info: |
   If Type(argument) is not Object, return false.
   If argument has a [[Construct]] internal method, return true.
   Return false.
-includes: [isConstructor.js, hidden-constructors.js]
+includes: [isConstructor.js, wellKnownIntrinsicObjects.js]
 features: [Reflect.construct]
 ---*/
 
+var AsyncGeneratorFunction = getWellKnownIntrinsicObject('%AsyncGeneratorFunction%');
 assert.sameValue(
   isConstructor(AsyncGeneratorFunction),
   true,
   'isConstructor(AsyncGeneratorFunction) must return true'
 );
 new AsyncGeneratorFunction();
-