refactored and restructured the code

Author: Hitansh159

controller/auth.js

@@ -1,4 +1,4 @@
-import OTPStore from "/models/OTPStore";
+import OTPStore from "#models/otpStore";
 import util, {logger} from "#util";
 import { authenticateUser, userExists, updatePassword } from "#services/user";
 
@@ -35,7 +35,7 @@ async function sendOTP(req, res) {
   const { uid, emailId } = req.body;
   if (await userExists(uid, emailId)) {
     const otp = Math.floor(1000 + Math.random() * 9000);
-    await OTPStore.findOneAndUpdate({ uid }, { otp: otp }, { upsert: true });
+    await OTPStore.update({uid: uid}, {otp: otp});
     util.sendOTP(emailId, otp);
     res.json({ res: "otp sent to emailID" });
   } else {
@@ -45,20 +45,19 @@ async function sendOTP(req, res) {
 
 async function resetPassword(req, res) {
   const { uid, otp, password } = req.body;
-  try{
-    const otpData=await OTPStore.find({uid});
-    if(otpData.otp ===otp ){
-      await updatePassword(uid,password)
-      res.json({res:"successfully updated password"})
-    }
-    else {
-      res.json({ err: "Incorrect OTP" });
+  const storedOtp = await OTPStore.read({uid: uid});
+  if (storedOtp[0].otp === `${otp}`) {
+    try {
+      await updatePassword(uid, password);
+      res.json({ res: "successfully updated password" });
+    } catch (error) {
+      logger.log("Error while updating", error)
+      res.status(500);
+      if (error.name === "UpdateError") res.json({ err: "Something went wrong while updating password" });
+      else res.json({ err: "something went wrong" });
     }
-
-  }
-  catch(error){
-    console.log(error)
-    res.json({res:"Something is wrong"})
+  } else {
+    res.json({ err: "incorrect otp" });
   }
 }
 

models/otpStore.js

@@ -1,10 +1,38 @@
 import connector from "#models/databaseUtil";
-const {Schema}=connector;
 
-const otpStoreSchema=new Schema({
-  uid:{type:String,unique:true,required:true},
-    otp:{type:String,required:true,unique:true}  
-})
+const otpStoreSchema = {
+  uid: { type: String, unique: true, required: true },
+  otp: { type: String, unique: true, required: true }
+}
 
-const OTPStore=connector.model("OTPStore",otpStoreSchema)
+const OTPStore = connector.model("OTPStore", otpStoreSchema)
+
+async function remove(filter) {
+  const res = await OTPStore.findOneAndDelete(filter);
+  return res;
+}
+
+async function create(uid, otp) {
+  const otpStore = new OTPStore({
+    uid,
+    otp
+  });
+  const otpDoc = await otpStore.save();
+  return otpDoc;
+}
+
+async function read(filter, limit = 1) {
+  const otpData = await OTPStore.find(filter).limit(limit);
+  return otpData;
+}
+
+async function update(filter, updateObject) {
+  const otpDoc = await OTPStore.findOneAndUpdate(filter, updateObject, { upsert: true, new: true });
+  return otpDoc;
+}
+
+
+export default {
+  create, read, update, remove,
+};