Merge pull request #342 from tcet-opensource/hotfixpatch10923

fixed problem with practical endpoint

Author: TejasNair9977

routes/practical.js

@@ -4,15 +4,15 @@ import practicalController from "#controller/practical";
 const router = express.Router();
 
 // Create a new Practical
-router.post("/practical/create", practicalController.addPractical);
+router.post("/create", practicalController.addPractical);
 
 // List Practical entities with optional filters
-router.get("/practical/list", practicalController.getPractical);
+router.get("/list", practicalController.getPractical);
 
 // Update Practical entities based on filters and update data
-router.post("/practical/update/:id", practicalController.updatePractical);
+router.post("/update/:id", practicalController.updatePractical);
 
 // Delete Practical entities based on filters
-router.delete("/practical/delete/:id", practicalController.deletePractical);
+router.delete("/delete/:id", practicalController.deletePractical);
 
 export default router;

services/practical.js

@@ -19,8 +19,8 @@ export async function createPractical({
 // Service function to update a Practical entity by ID
 export async function updatePracticalById(id, data) {
   try {
-    const updated = await Practical.updateOne({ _id: id }, data);
-    if (updated.nModified > 0) {
+    const updated = await Practical.update({ _id: id }, data);
+    if (updated) {
       return updated;
     }
     throw new databaseError.DataEntryError("practical");
@@ -32,10 +32,10 @@ export async function updatePracticalById(id, data) {
 // Service function to retrieve a list of Practical entities based on filters
 export async function listPractical(filter) {
   try {
-    const practicalList = await Practical.find(filter);
+    const practicalList = await Practical.read(filter);
     return practicalList;
   } catch (error) {
-    throw new databaseError.DataRetrievalError("practical");
+    throw new databaseError.DataEntryError("practical");
   }
 }