added logger at all catchers

Author: Hitansh159

controller/auth.js

@@ -1,4 +1,4 @@
-import util from "#util";
+import util, {logger} from "#util";
 import { authenticateUser, userExists, updatePassword } from "#services/user";
 
 const otpStore = {};
@@ -17,6 +17,7 @@ async function login(req, res) {
     userDetails.token = token;
     res.json({ res: "welcome", user: userDetails });
   } catch (error) {
+    logger.error("Error while login", error)
     if (error.name === "UserDoesNotExist") {
       res.status(403);
       res.json({ err: "Incorrect ID password" });
@@ -50,6 +51,7 @@ async function resetPassword(req, res) {
       await updatePassword(uid, password);
       res.json({ res: "successfully updated password" });
     } catch (error) {
+      logger.log("Error while updating", error)
       res.status(500);
       if (error.name === "UpdateError") res.json({ err: "Something went wrong while updating password" });
       else res.json({ err: "something went wrong" });

controller/user.js

@@ -1,4 +1,5 @@
 import { allUsers, createUser } from "#services/user";
+import { logger } from "#util";
 
 async function addUser(req, res) {
   const {
@@ -8,6 +9,8 @@ async function addUser(req, res) {
     const newUser = await createUser(name, password, emailId, uid, userType);
     res.json({ res: `added user ${newUser.id}` });
   } catch (error) {
+    logger.error("Error while inserting", error)
+    res.status(500)
     res.json({ err: "Error while inserting in DB" });
   }
 }

models/user.js

@@ -25,19 +25,18 @@ async function create(name, password, emailId, uid, userType) {
     uid,
     userType,
   });
-  const userDoc = await user.save().catch((err) => { logger.error(err); });
+  const userDoc = await user.save();
   return userDoc;
 }
 
 async function read(filter, limit = 1) {
-  const userData = await User.find(filter).limit(limit).catch((err) => { logger.error(err); });
+  const userData = await User.find(filter).limit(limit);
   return userData;
 }
 
 async function update(filter, updateObject) {
   const user = await User.findOneAndUpdate(filter, updateObject, { new: true });
-  if (user.id) return user;
-  return "Error";
+  return user;
 }
 
 export default {

services/user.js

@@ -3,7 +3,7 @@ import databaseError from "#error/database";
 
 export async function authenticateUser(uid, password) {
   const user = await User.read({ uid, password }, 1);
-  if (user[0].uid === uid) {
+  if (user[0]?.uid === uid) {
     return user[0];
   }
   throw new databaseError.UserDoesNotExistError();