Skip to content

Commit b2ad704

Browse files
committed
fix(ui): Disable share_pos() inside RoomListService.
This patch disables the call to `share_pos()` inside the `RoomListService` because it creates slowness we need to investigate.
1 parent 5a1392e commit b2ad704

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

crates/matrix-sdk-ui/src/room_list_service/mod.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,10 @@ impl RoomListService {
136136
}))
137137
.with_typing_extension(assign!(http::request::Typing::default(), {
138138
enabled: Some(true),
139-
}))
140-
// We don't deal with encryption device messages here so this is safe
141-
.share_pos();
139+
}));
140+
// TODO: Re-enable once we know it creates slowness.
141+
// // We don't deal with encryption device messages here so this is safe
142+
// .share_pos();
142143

143144
let sliding_sync = builder
144145
.add_cached_list(

crates/matrix-sdk-ui/tests/integration/room_list_service.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -591,6 +591,7 @@ async fn test_sync_resumes_from_previous_state() -> Result<(), Error> {
591591
}
592592

593593
#[async_test]
594+
#[ignore] // `share_pos()` has been disabled in the room list, see there to learn more.
594595
async fn test_sync_resumes_from_previous_state_after_restart() -> Result<(), Error> {
595596
let tmp_dir = TempDir::new().unwrap();
596597
let store_path = tmp_dir.path();

0 commit comments

Comments
 (0)