Merge rust-bitcoin#232: Implement submitheader and test

1acb6b7 Implement submit header and test (Jamil Lambert, PhD)
cc2992e Correct typo (Jamil Lambert, PhD)

Pull request description:

  Add a test and client macro for `submitheader` for v18 and up. There are
  no changes up to v29.

  Correct the typo that said  `return nothing` to `returns nothing`

ACKs for top commit:
  tcharding:
    ACK 1acb6b7

Tree-SHA512: 0f3f1c7cbcd635157bff77b10e9512ced16bd4d85ab91105373cff7df841ad12e92e61ceae42ee11c894e465436619c288d5fa93fdb7078af82c16931c7aef6d

Author: tcharding

client/src/client_sync/v18/mining.rs

@@ -0,0 +1,27 @@
+// SPDX-License-Identifier: CC0-1.0
+
+//! Macros for implementing JSON-RPC methods on a client.
+//!
+//! Specifically this is methods found under the `== Mining ==` section of the
+//! API docs of Bitcoin Core `v0.18`.
+//!
+//! All macros require `Client` to be in scope.
+//!
+//! See or use the `define_jsonrpc_minreq_client!` macro to define a `Client`.
+
+/// Implements Bitcoin Core JSON-RPC API method `submitheader`.
+#[macro_export]
+macro_rules! impl_client_v18__submit_header {
+    () => {
+        impl Client {
+            pub fn submit_header(&self, header: &bitcoin::block::Header) -> Result<()> {
+                let hexdata = bitcoin::consensus::encode::serialize_hex(header);
+                match self.call("submitheader", &[hexdata.into()]) {
+                    Ok(serde_json::Value::Null) => Ok(()),
+                    Ok(res) => Err(Error::Returned(res.to_string())),
+                    Err(err) => Err(err.into()),
+                }
+            }
+        }
+    };
+}

client/src/client_sync/v18/mod.rs

@@ -5,6 +5,7 @@
 //! We ignore option arguments unless they effect the shape of the returned JSON data.
 
 pub mod control;
+pub mod mining;
 pub mod network;
 pub mod raw_transactions;
 pub mod util;
@@ -74,6 +75,7 @@ crate::impl_client_v17__get_mining_info!();
 crate::impl_client_v17__get_network_hashes_per_second!();
 crate::impl_client_v17__prioritise_transaction!();
 crate::impl_client_v17__submit_block!();
+crate::impl_client_v18__submit_header!();
 
 // == Network ==
 crate::impl_client_v17__add_node!();

client/src/client_sync/v19/mod.rs

@@ -71,6 +71,7 @@ crate::impl_client_v17__get_mining_info!();
 crate::impl_client_v17__get_network_hashes_per_second!();
 crate::impl_client_v17__prioritise_transaction!();
 crate::impl_client_v17__submit_block!();
+crate::impl_client_v18__submit_header!();
 
 // == Network ==
 crate::impl_client_v17__add_node!();

client/src/client_sync/v20/mod.rs

@@ -68,6 +68,7 @@ crate::impl_client_v17__get_mining_info!();
 crate::impl_client_v17__get_network_hashes_per_second!();
 crate::impl_client_v17__prioritise_transaction!();
 crate::impl_client_v17__submit_block!();
+crate::impl_client_v18__submit_header!();
 
 // == Network ==
 crate::impl_client_v17__add_node!();

client/src/client_sync/v21/mod.rs

@@ -70,6 +70,7 @@ crate::impl_client_v17__get_mining_info!();
 crate::impl_client_v17__get_network_hashes_per_second!();
 crate::impl_client_v17__prioritise_transaction!();
 crate::impl_client_v17__submit_block!();
+crate::impl_client_v18__submit_header!();
 
 // == Network ==
 crate::impl_client_v17__add_node!();

client/src/client_sync/v22/mod.rs

@@ -70,6 +70,7 @@ crate::impl_client_v17__get_mining_info!();
 crate::impl_client_v17__get_network_hashes_per_second!();
 crate::impl_client_v17__prioritise_transaction!();
 crate::impl_client_v17__submit_block!();
+crate::impl_client_v18__submit_header!();
 
 // == Network ==
 crate::impl_client_v17__add_node!();

client/src/client_sync/v23/mod.rs

@@ -72,6 +72,7 @@ crate::impl_client_v17__get_mining_info!();
 crate::impl_client_v17__get_network_hashes_per_second!();
 crate::impl_client_v17__prioritise_transaction!();
 crate::impl_client_v17__submit_block!();
+crate::impl_client_v18__submit_header!();
 
 // == Network ==
 crate::impl_client_v17__add_node!();

client/src/client_sync/v24/mod.rs

@@ -69,6 +69,7 @@ crate::impl_client_v17__get_mining_info!();
 crate::impl_client_v17__get_network_hashes_per_second!();
 crate::impl_client_v17__prioritise_transaction!();
 crate::impl_client_v17__submit_block!();
+crate::impl_client_v18__submit_header!();
 
 // == Network ==
 crate::impl_client_v17__add_node!();

client/src/client_sync/v25/mod.rs

@@ -69,6 +69,7 @@ crate::impl_client_v17__get_mining_info!();
 crate::impl_client_v17__get_network_hashes_per_second!();
 crate::impl_client_v17__prioritise_transaction!();
 crate::impl_client_v17__submit_block!();
+crate::impl_client_v18__submit_header!();
 
 // == Network ==
 crate::impl_client_v17__add_node!();

client/src/client_sync/v26/mod.rs

@@ -74,6 +74,7 @@ crate::impl_client_v17__get_network_hashes_per_second!();
 crate::impl_client_v26__get_prioritised_transactions!();
 crate::impl_client_v17__prioritise_transaction!();
 crate::impl_client_v17__submit_block!();
+crate::impl_client_v18__submit_header!();
 
 // == Network ==
 crate::impl_client_v17__add_node!();