Standardize version format in docs

There is a variation in the way the version number is written in the
docs. Some are preceded by a 0 and some arn't. Core states the versions
up to and including 21 with preceding 0, and for 22 and above without.

Change all version numbers in the text to be v0.17 - v0.21, and v22 -
v29 to match core.

Author: jamillambert

client/src/client_sync/v21/wallet.rs

@@ -3,7 +3,7 @@
 //! Macros for implementing JSON-RPC methods on a client.
 //!
 //! Specifically this is methods found under the `== Wallet ==` section of the
-//! API docs of Bitcoin Core `v21`.
+//! API docs of Bitcoin Core `v0.21`.
 //!
 //! All macros require `Client` to be in scope.
 //!

client/src/client_sync/v23/blockchain.rs

@@ -3,7 +3,7 @@
 //! Macros for implementing JSON-RPC methods on a client.
 //!
 //! Specifically this is methods found under the `== Blockchain ==` section of the
-//! API docs of Bitcoin Core `v0.23`.
+//! API docs of Bitcoin Core `v23`.
 //!
 //! All macros require `Client` to be in scope.
 //!

client/src/client_sync/v26/blockchain.rs

@@ -3,7 +3,7 @@
 //! Macros for implementing JSON-RPC methods on a client.
 //!
 //! Specifically this is methods found under the `== Blockchain ==` section of the
-//! API docs of Bitcoin Core `v0.26`.
+//! API docs of Bitcoin Core `v26`.
 //!
 //! All macros require `Client` to be in scope.
 //!

client/src/client_sync/v26/mining.rs

@@ -3,7 +3,7 @@
 //! Macros for implementing JSON-RPC methods on a client.
 //!
 //! Specifically this is methods found under the `== Mining ==` section of the
-//! API docs of Bitcoin Core `v0.26`.
+//! API docs of Bitcoin Core `v26`.
 //!
 //! All macros require `Client` to be in scope.
 //!

integration_test/tests/generating.rs

@@ -9,7 +9,7 @@ use node::vtype::*;             // All the version specific types.
 use node::mtype;
 
 #[test]
-// The `generate` method was deprecated in Core v18 and was removed in v19.
+// The `generate` method was deprecated in Core v0.18 and was removed in v0.19.
 #[cfg(feature = "v17")]
 fn generating__generate__modelled() {
     const NBLOCKS: usize = 10;

integration_test/tests/mining.rs

@@ -211,4 +211,4 @@ fn mining__submit_block_with_dummy_coinbase(node: &Node, bt: &mtype::GetBlockTem
     let _ = node.client.submit_block(&block).expect("submitblock");
 }
 
-// TODO: submitheader "hexdata" (v18 onwards)
+// TODO: submitheader "hexdata" (v0.18 onwards)

integration_test/tests/raw_transactions.rs

@@ -13,7 +13,7 @@ use node::{mtype, Input, Output};
 use node::vtype::*;             // All the version specific types.
 
 #[test]
-#[cfg(not(feature = "v17"))]    // analyzepsbt was added in v18.
+#[cfg(not(feature = "v17"))]    // analyzepsbt was added in v0.18.
 fn raw_transactions__analyze_psbt__modelled() {
     let node = Node::with_wallet(Wallet::Default, &[]);
     node.fund_wallet();
@@ -427,7 +427,7 @@ fn raw_transactions__submit_package__modelled() {
 fn raw_transactions__test_mempool_accept__modelled() {}
 
 #[test]
-#[cfg(not(feature = "v17"))]    // utxoupdatepsbt was added in v18.
+#[cfg(not(feature = "v17"))]    // utxoupdatepsbt was added in v0.18.
 fn raw_transactions__utxo_update_psbt() {}
 
 // Manipulates raw transactions.
@@ -487,7 +487,7 @@ fn create_sign_send(node: &Node) {
 //
 // Calls the following RPC methods:
 // - create_raw_transaction
-// - sign_raw_transaction_with_key (sign_raw_transaction was deprecated in v17).
+// - sign_raw_transaction_with_key (sign_raw_transaction was deprecated in v0.17).
 // - send_raw_transaction
 //
 // TODO: Work out how to get a private key without using `dumpprivkey`.
@@ -544,7 +544,7 @@ fn create_sign_with_key_send(node: &Node) {
 //
 // Calls the following RPC methods:
 // - fund_raw_transaction
-// - sign_raw_transaction_with_wallet (sign_raw_transaction was deprecated in v17).
+// - sign_raw_transaction_with_wallet (sign_raw_transaction was deprecated in v0.17).
 // - send_raw_transaction
 fn create_fund_sign_send(node: &Node) {
     let (_addr, _tx, txid, _tx_out, vout) = create_utxo(node);

types/src/lib.rs

@@ -177,7 +177,7 @@ pub fn compact_size_decode(slice: &mut &[u8]) -> u64 {
 ///
 /// This is used by methods in the blockchain section and in the raw transaction section (i.e raw
 /// transaction and psbt methods). The shape changed in Core v22 but the new shape is fully
-/// backwards compatible so we only provide it not a v17 specific type. The `mtype::ScriptPubkey`
+/// backwards compatible so we only provide it not a v0.17 specific type. The `mtype::ScriptPubkey`
 /// mirrors this design (but with concrete `rust-bitcoin` types).
 #[derive(Clone, Debug, PartialEq, Eq, Deserialize, Serialize)]
 pub struct ScriptPubkey {

types/src/model/blockchain.rs

@@ -407,15 +407,15 @@ pub struct MempoolEntry {
     pub ancestor_size: u32,
     /// Hash of serialized transaction, including witness data.
     pub wtxid: Wtxid,
-    /// (No docs in Core v17.)
+    /// (No docs in Core v0.17.)
     pub fees: MempoolEntryFees,
     /// Unconfirmed transactions used as inputs for this transaction (parent transaction id).
     pub depends: Vec<Txid>,
     /// Unconfirmed transactions spending outputs from this transaction (child transaction id).
     pub spent_by: Vec<Txid>,
 }
 
-/// (No docs in Core v17.)
+/// (No docs in Core v0.17.)
 #[derive(Clone, Debug, PartialEq, Deserialize, Serialize)]
 pub struct MempoolEntryFees {
     /// Transaction fee in BTC.

types/src/psbt/mod.rs

@@ -196,7 +196,7 @@ pub struct Bip32Deriv {
 }
 
 /// The key source data for a BIP-32 derivation.
-// In v17 the BIP-32 derivation for inputs is a map of pubkey to this type.
+// In v0.17 the BIP-32 derivation for inputs is a map of pubkey to this type.
 #[derive(Clone, Debug, PartialEq, Deserialize, Serialize)]
 pub struct InputKeySource {
     /// The fingerprint of the master key.