Merge pull request rust-bitcoin#82 from tcharding/03-10-get-transaction

Use `SignedAmount` when converting `gettransaction` amount to model

Author: tcharding

types/src/model/wallet.rs

@@ -283,7 +283,7 @@ pub struct GetReceivedByAddress(pub Amount);
 pub struct GetTransaction {
     /// The transaction amount.
     #[serde(default, with = "bitcoin::amount::serde::as_btc")]
-    pub amount: Amount,
+    pub amount: SignedAmount,
     /// The amount of the fee.
     ///
     /// This is negative and only available for the 'send' category of transactions.

types/src/v17/wallet/into.rs

@@ -328,7 +328,7 @@ impl GetTransaction {
     pub fn into_model(self) -> Result<model::GetTransaction, GetTransactionError> {
         use GetTransactionError as E;
 
-        let amount = Amount::from_btc(self.amount).map_err(E::Amount)?;
+        let amount = SignedAmount::from_btc(self.amount).map_err(E::Amount)?;
         let fee = self.fee.map(|fee| SignedAmount::from_btc(fee).map_err(E::Fee)).transpose()?;
 
         let block_hash =

types/src/v17/wallet/mod.rs

@@ -21,7 +21,7 @@ pub use self::error::*;
 //
 // The following structs are very similar but have slightly different fields and docs.
 // - GetTransaction
-// - ListSinceLastBlockTransaction
+// - ListSinceBlockTransaction
 // - ListTransactionsItem
 
 /// Returned as part of `getaddressesbylabel` and `getaddressinfo`