Merge rust-bitcoin#220: Implement ping method and test

8b1f578 Implement ping method and test (GideonBature)

Pull request description:

  The JSON-RPC method `ping` does return null. We want to test this to catch any changes in behavior in future Core versions.

  This PR adds a client function that errors if the return value is anything other than `null`, along with an integration test that calls this function.

  Ref: [rust-bitcoin#116](rust-bitcoin#116)

ACKs for top commit:
  tcharding:
    ACK 8b1f578

Tree-SHA512: c2626a22f96179e22154a8830a53d6b2568c959515244445dc6481572bde8f45ea9eec16f82bafa19ad8c31814c49d6ccf2e3d0a1d279191548e420d3d15d55d

Author: tcharding

client/src/client_sync/v17/mod.rs

@@ -79,6 +79,7 @@ crate::impl_client_v17__get_connection_count!();
 crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v17__get_peer_info!();
+crate::impl_client_v17__ping!();
 crate::impl_client_v17__set_ban!();
 
 // == Rawtransactions ==

client/src/client_sync/v17/network.rs

@@ -119,6 +119,22 @@ macro_rules! impl_client_v17__get_peer_info {
     };
 }
 
+/// Implements Bitcoin Core JSON-RPC API method `ping`
+#[macro_export]
+macro_rules! impl_client_v17__ping {
+    () => {
+        impl Client {
+            pub fn ping(&self) -> Result<()> {
+                match self.call("ping", &[]) {
+                    Ok(serde_json::Value::Null) => Ok(()),
+                    Ok(res) => Err(Error::Returned(res.to_string())),
+                    Err(err) => Err(err.into()),
+                }
+            }
+        }
+    };
+}
+
 /// Implements Bitcoin Core JSON-RPC API method `setban`
 #[macro_export]
 macro_rules! impl_client_v17__set_ban {

client/src/client_sync/v18/mod.rs

@@ -84,6 +84,7 @@ crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();
 crate::impl_client_v17__get_peer_info!();
+crate::impl_client_v17__ping!();
 crate::impl_client_v17__set_ban!();
 
 // == Rawtransactions ==

client/src/client_sync/v19/mod.rs

@@ -82,6 +82,7 @@ crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();
 crate::impl_client_v17__get_peer_info!();
+crate::impl_client_v17__ping!();
 crate::impl_client_v17__set_ban!();
 
 // == Rawtransactions ==

client/src/client_sync/v20/mod.rs

@@ -79,6 +79,7 @@ crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();
 crate::impl_client_v17__get_peer_info!();
+crate::impl_client_v17__ping!();
 crate::impl_client_v17__set_ban!();
 
 // == Rawtransactions ==

client/src/client_sync/v21/mod.rs

@@ -81,6 +81,7 @@ crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();
 crate::impl_client_v17__get_peer_info!();
+crate::impl_client_v17__ping!();
 crate::impl_client_v17__set_ban!();
 
 // == Rawtransactions ==

client/src/client_sync/v22/mod.rs

@@ -81,6 +81,7 @@ crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();
 crate::impl_client_v17__get_peer_info!();
+crate::impl_client_v17__ping!();
 crate::impl_client_v17__set_ban!();
 
 // == Rawtransactions ==

client/src/client_sync/v23/mod.rs

@@ -83,6 +83,7 @@ crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();
 crate::impl_client_v17__get_peer_info!();
+crate::impl_client_v17__ping!();
 crate::impl_client_v17__set_ban!();
 
 // == Rawtransactions ==

client/src/client_sync/v24/mod.rs

@@ -80,6 +80,7 @@ crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();
 crate::impl_client_v17__get_peer_info!();
+crate::impl_client_v17__ping!();
 crate::impl_client_v17__set_ban!();
 
 // == Rawtransactions ==

client/src/client_sync/v25/mod.rs

@@ -80,6 +80,7 @@ crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();
 crate::impl_client_v17__get_peer_info!();
+crate::impl_client_v17__ping!();
 crate::impl_client_v17__set_ban!();
 
 // == Rawtransactions ==