Raise MSRV to 1.51.0

In 8273b80 we (I) added a dep on `hex` which silently raised the MSRV
of this branch to Rust 1.51.0

Because of how we test on this branch this was not caught by CI. The
version with this change has been released for 2 years now and no-one
has complained implying that no-one is building with Rust 1.41

Although it is a violation of semver, lets just bump the MSRV in a
point release and live with the mistake.

Includes removal of `unsigned_abs` since it is now available with this MSRV.

Author: tcharding

.github/workflows/rust.yml

@@ -61,30 +61,30 @@ jobs:
         run: ./contrib/test.sh
 
   MSRV:
-    name: Test - 1.41.1 toolchain
+    name: Test - 1.51.0 toolchain
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
     steps:
       - name: Checkout Crate
         uses: actions/checkout@v3
       - name: Checkout Toolchain
-        uses: dtolnay/rust-toolchain@1.41.1
+        uses: dtolnay/rust-toolchain@1.51.0
       - name: Running test script
         env:
           DO_FEATURE_MATRIX: true
         run: ./contrib/test.sh
 
   NoStd:
-    name: Test - 1.47 toolchain
+    name: Test - 1.51.0 toolchain
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
     steps:
       - name: Checkout Crate
         uses: actions/checkout@v3
       - name: Checkout Toolchain
-        uses: dtolnay/rust-toolchain@1.47
+        uses: dtolnay/rust-toolchain@1.51.0
       - name: Running test script
         env:
           DO_NO_STD: true

README.md

@@ -76,13 +76,11 @@ For more information please see `./CONTRIBUTING.md`.
 
 ## Minimum Supported Rust Version (MSRV)
 
-This library should always compile with any combination of features (minus
-`no-std`) on **Rust 1.41.1** or **Rust 1.47** with `no-std`.
+This library should always compile with any combination of features on **Rust 1.51.0**.
 
-To build with the MSRV you will need to pin some dependencies (also for `no-std`):
+To build with the MSRV you may need to pin some dependencies:
 ```
-cargo update -p serde --precise 1.0.156
-cargo update -p syn --precise 1.0.107
+cargo update -p cc --precise 1.0.170
 ```
 
 ## Installing Rust

bitcoin/CHANGELOG.md

@@ -1,3 +1,11 @@
+# 0.30.3 - 2025-12-09
+
+- Bump the MSRV to Rust 1.51.0
+
+Sorry, we accidentally did this 2 years ago in 0.30.2, since no-one
+complained we decided to keep it even though it is a semver violation.
+If you need to build with Rust 1.41 please pin to `v0.30.1`.
+
 # 0.30.2 - 2023-11-16
 
 - Expose valid (min, max) difficulty transition thresholds [#1820](Expose valid (min, max) difficulty transition thresholds)

bitcoin/contrib/test.sh

@@ -23,22 +23,6 @@ if cargo --version | grep beta; then
     STABLE=false
 fi
 
-# Pin dependencies as required if we are using MSRV toolchain.
-if cargo --version | grep "1\.41"; then
-    cargo update -p cc --precise 1.0.77
-    # 1.0.157 uses syn 2.0 which requires edition 2018
-    cargo update -p serde --precise 1.0.156
-
-    # latest arrayvec build fails because of `track_caller`.
-    cargo update -p arrayvec --precise 0.7.2
-fi
-
-# Pin dependencies as above (required for no-std tests that use Rust 1.47 toolchain).
-if cargo --version | grep "1\.47"; then
-    cargo update -p serde --precise 1.0.156
-    cargo update -p syn --precise 1.0.107
-fi
-
 # We should not have any duplicate dependencies. This catches mistakes made upgrading dependencies
 # in one crate and not in another (e.g. upgrade bitcoin_hashes in bitcoin but not in secp).
 duplicate_dependencies=$(

bitcoin/src/amount.rs

@@ -261,7 +261,7 @@ fn parse_signed_to_satoshi(
             // into a less precise amount. That is not allowed unless
             // there are no decimals and the last digits are zeroes as
             // many as the difference in precision.
-            let last_n = unsigned_abs(precision_diff).into();
+            let last_n = precision_diff.unsigned_abs().into();
             if is_too_precise(s, last_n) {
                 match s.parse::<i64>() {
                     Ok(0_i64) => return Ok((is_negative, 0)),
@@ -374,9 +374,6 @@ fn dec_width(mut num: u64) -> usize {
     width
 }
 
-// NIH due to MSRV, impl copied from `core::i8::unsigned_abs` (introduced in Rust 1.51.1).
-fn unsigned_abs(x: i8) -> u8 { x.wrapping_abs() as u8 }
-
 fn repeat_char(f: &mut dyn fmt::Write, c: char, count: usize) -> fmt::Result {
     for _ in 0..count {
         f.write_char(c)?;
@@ -410,7 +407,7 @@ fn fmt_satoshi_in(
             trailing_decimal_zeros = options.precision.unwrap_or(0);
         }
         Ordering::Less => {
-            let precision = unsigned_abs(precision);
+            let precision = precision.unsigned_abs();
             let divisor = 10u64.pow(precision.into());
             num_before_decimal_point = satoshi / divisor;
             num_after_decimal_point = satoshi % divisor;

clippy.toml

@@ -1 +1 @@
-msrv = "1.41.1"
+msrv = "1.51.1"